Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-runner-watch-mode is flaky #49605

Open
joyeecheung opened this issue Sep 11, 2023 · 6 comments
Open

test-runner-watch-mode is flaky #49605

joyeecheung opened this issue Sep 11, 2023 · 6 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test_runner Issues and PRs related to the test runner subsystem.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Sep 11, 2023 •
edited
Loading

Reason parallel/test-runner-watch-mode
Type JS_TEST_FAILURE
Failed PR 5 (#49419, #49559, #49565, #49575, #49582)
Appeared test-osuosl-ubuntu2004_container-armv7l-1, test-digitalocean-ubuntu1804_sharedlibs_container-x64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/53812/
Last CI https://ci.nodejs.org/job/node-test-pull-request/53856/
Example 
not ok 2874 parallel/test-runner-watch-mode
  ---
  duration_ms: 360086.13100
  severity: fail
  exitcode: -15
  stack: |-
    timeout
    TAP version 13
    Updating /home/iojs/tmp/.tmp.2382/dependent.js
    Updating /home/iojs/tmp/.tmp.2382/dependent.js
    Updating /home/iojs/tmp/.tmp.2382/dependent.js
    Updating /home/iojs/tmp/.tmp.2382/dependent.js
    Updating /home/iojs/tmp/.tmp.2382/dependent.js
    Updating /home/iojs/tmp/.tmp.2382/dependent.js
    Updating /home/iojs/tmp/.tmp.2382/dependent.js
    Updating /home/iojs/tmp/.tmp.2382/dependent.js
    Updating /home/iojs/tmp/.tmp.2382/dependent.js
    Updating /home/iojs/tmp/.tmp.2382/dependent.js
    Updating /home/iojs/tmp/.tmp.2382/dependent.js
    # Subtest: test runner watch mode
        # Subtest: should run tests repeatedly
        ok 1 - should run tests repeatedly
          ---
          duration_ms: 1301.051293
          ...

Refs: nodejs/reliability#662

From the full log it looks like something is quite wrong in the test, it keeps getting stuck at tons of Updating /home/iojs/node-tmp/.tmp.2479/dependency.js until the 2 minute timeout is reached (my guess is it has more to do with how the test is written)

https://ci.nodejs.org/job/node-test-binary-armv7l/7355/RUN_SUBSET=js,nodes=ubuntu2004-armv7l/consoleText
@joyeecheung
Copy link
Member Author

cc @nodejs/test_runner

@joyeecheung joyeecheung added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Sep 11, 2023
@MoLow
Copy link
Member

MoLow commented Sep 11, 2023 •
edited
Loading

is anyone able to reproduce with tools/test.py --repeat=1000 test/parallel/test-runner-watch-mode.mjs? on my machine it passes smoothly

@aduh95
Copy link
Contributor

aduh95 commented Sep 11, 2023 via email

@joyeecheung
Copy link
Member Author

The flakes in the CI only show up in Linux ARM and Linux + shared library. I am guessing using a similar setup may help reproducing the issues. Or you can try using the the CI boxes.

@joyeecheung
Copy link
Member Author

Looks like this also comes up to people running Ubuntu 22.04 locally too #49513

This was referenced Sep 12, 2023
Merged
Closed
nodejs-github-bot pushed a commit that referenced this issue Sep 14, 2023
@joyeecheung
test: mark test-runner-watch-mode as flaky
b289c6d 
PR-URL: #49627
Refs: #49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@joyeecheung joyeecheung mentioned this issue Sep 25, 2023
Closed
@joyeecheung joyeecheung added the test_runner Issues and PRs related to the test runner subsystem. label Sep 25, 2023
ruyadorno pushed a commit that referenced this issue Sep 28, 2023
@joyeecheung @ruyadorno
test: mark test-runner-watch-mode as flaky
ab3afb3 
PR-URL: #49627
Refs: #49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@cjihrig cjihrig mentioned this issue Oct 21, 2023
Closed
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@joyeecheung @alexfernandez
test: mark test-runner-watch-mode as flaky
e5619f9 
PR-URL: nodejs#49627
Refs: nodejs#49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this issue Nov 27, 2023
@joyeecheung @targos
test: mark test-runner-watch-mode as flaky
5df2352 
PR-URL: #49627
Refs: #49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
test: mark test-runner-watch-mode as flaky
6305d66 
PR-URL: nodejs/node#49627
Refs: nodejs/node#49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
test: mark test-runner-watch-mode as flaky
2201bcf 
PR-URL: nodejs/node#49627
Refs: nodejs/node#49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Aug 15, 2024

Happened again on https://ci.nodejs.org/job/node-test-commit-linuxone/45127/nodes=rhel8-s390x/

This was referenced Aug 24, 2024
Open
Closed
@lpinca lpinca mentioned this issue Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joyeecheung @MoLow @aduh95