Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: Missing use cases with module customization hooks #50392

Open
GeoffreyBooth opened this issue Oct 25, 2023 · 2 comments
Open

Discussion: Missing use cases with module customization hooks #50392

GeoffreyBooth opened this issue Oct 25, 2023 · 2 comments
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders module Issues and PRs related to the module subsystem.

Comments

@GeoffreyBooth
Copy link
Member

GeoffreyBooth commented Oct 25, 2023 •
edited
Loading

Re #50356 (comment), what are the use cases that we want to support that are not currently possible via the module customization hooks? The current hooks were designed to satisfy the cases here: https://github.com/nodejs/loaders/blob/main/doc/use-cases.md.

Put another way, if monkey-patching the CommonJS loader were no longer possible, what use cases that we want to support would be no longer possible?

@nodejs/loaders @nodejs/vm @nodejs/performance @nodejs/tsc
@GeoffreyBooth GeoffreyBooth added module Issues and PRs related to the module subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders labels Oct 25, 2023
@GeoffreyBooth GeoffreyBooth mentioned this issue Oct 25, 2023
Open
@koshic

This comment was marked as off-topic.

Sign in to view
@GeoffreyBooth

This comment was marked as off-topic.

Sign in to view
@ghost ghost mentioned this issue Nov 8, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GeoffreyBooth @koshic