flaky: test-fs-readfile-tostring-fail

[mhdawson]

Test

test-fs-readfile-tostring-fail

Platform

macOS x64

Console output

Error Message
fail (7)
Stacktrace
---
duration_ms: 156.304
exitcode: 7
severity: fail
...

Build links

• https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx11-x64/56131/

Additional information

No response

[richardlau]

FWIW this is an out of disk space issue:

06:42:28 not ok 3678 pummel/test-fs-readfile-tostring-fail
06:42:28   ---
06:42:28   duration_ms: 156.30400
06:42:28   severity: fail
06:42:28   exitcode: 7
06:42:28   stack: |-
06:42:28     /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx11-x64/test/pummel/test-fs-readfile-tostring-fail.js:76
06:42:28       throw err;
06:42:28       ^
06:42:28     
06:42:28     AssertionError [ERR_ASSERTION]: ifError got unwanted exception: ENOSPC: no space left on device, write
06:42:28         at Object.callback (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx11-x64/test/pummel/test-fs-readfile-tostring-fail.js:34:37)
06:42:28         at callback (node:internal/streams/writable:757:21)
06:42:28         at onwriteError (node:internal/streams/writable:597:3)
06:42:28         at onwrite (node:internal/streams/writable:640:7)
06:42:28         at node:internal/fs/streams:513:5
06:42:28         at node:internal/fs/streams:455:14
06:42:28         at FSReqCallback.wrapper [as oncomplete] (node:fs:951:5) {
06:42:28       generatedMessage: false,
06:42:28       code: 'ERR_ASSERTION',
06:42:28       actual: [Error: ENOSPC: no space left on device, write] {
06:42:28         errno: -28,
06:42:28         code: 'ENOSPC',
06:42:28         syscall: 'write'
06:42:28       },
06:42:28       expected: null,
06:42:28       operator: 'ifError'
06:42:28     }
06:42:28     
06:42:28     Node.js v22.0.0-pre
06:42:28   ...

Interestingly the test has a check for disk space but the test still failed which suggests either the check is wrong or the space was filled while the test was running between the check and subsequent usage.

node/test/pummel/test-fs-readfile-tostring-fail.js

Lines 18 to 20 in 1b60054

	if (!tmpdir.hasEnoughSpace(kStringMaxLength)) {
	common.skip(`Not enough space in ${tmpdir.path}`);
	}

[pluris]

It's actually using more capacity in stream.write() than is written to kStringMaxLength.
There are 201 buffers used in the for loop.

node/test/pummel/test-fs-readfile-tostring-fail.js

Lines 18 to 20 in 1b60054

	if (!tmpdir.hasEnoughSpace(kStringMaxLength)) {
	common.skip(`Not enough space in ${tmpdir.path}`);
	}

node/test/pummel/test-fs-readfile-tostring-fail.js

Lines 29 to 36 in 1b60054

	const size = kStringMaxLength / 200;
	const a = Buffer.alloc(size, 'a');
	let expectedSize = 0;
	for (let i = 0; i < 201; i++) {
	stream.write(a, (err) => { assert.ifError(err); });
	expectedSize += a.length;
	}

[lpinca]

It seems that it is no longer flaky, closing.