Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: differentiate describe from it in event:enqueue so we can have a total test count #51235

Closed
icetbr opened this issue Dec 20, 2023 · 8 comments · Fixed by #54049
Closed
Labels
feature request Issues that request new features to be added to Node.js. good first issue Issues that are suitable for first-time contributors. test_runner Issues and PRs related to the test runner subsystem.

Comments

@icetbr
Copy link

icetbr commented Dec 20, 2023

What is the problem this feature will solve?

I have 10.000 tests that run in 10 minutes. I want to have a sense of progress.

What is the feature you are proposing to solve the problem?

Add the type of the test to the enqueue event might be enough, whether it is a test or a test group; it vs describe.

What alternatives have you considered?

No response

@icetbr icetbr added the feature request Issues that request new features to be added to Node.js. label Dec 20, 2023
@MoLow
Copy link
Member

MoLow commented Dec 23, 2023

are you interested on opening a PR for this?

@MoLow MoLow added good first issue Issues that are suitable for first-time contributors. test_runner Issues and PRs related to the test runner subsystem. labels Dec 23, 2023
@icetbr
Copy link
Author

icetbr commented Dec 23, 2023

Sure! There is already the type in some events, hopefully I just have to use the same logic. Should I proceed?

@Medhansh404
Copy link

@MoLow i have gone through the issue and what i came up with the approach of adding the type of event along with emit('enqueue', { test: ${i}, testType }); here on each iteration for tests. I can open a PR if you can confirm if this can be a way to solve things here. would appreciate the feedback!! :)

@MoLow
Copy link
Member

MoLow commented Jan 2, 2024

yes ,that makes sense

@Medhansh404
Copy link

as i am working on the issue i can no longer find the significance of type of test rather we can do a log of no. of completed test out of total test, which we can increment on each completed test here, i find this better. what do you think @icetbr @MoLow ?

@icetbr
Copy link
Author

icetbr commented Jan 3, 2024

I can't tell if that will work. The current events make it impossible to distinguish between a describe and an it. If that will help with a 30 out of 10000 tests situation, I'm fine with that.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the never-stale Mark issue so that it is never considered stale label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Jul 2, 2024
@EddieAbbondanzio
Copy link
Contributor

I'm gonna pick this up since it seems to be stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. good first issue Issues that are suitable for first-time contributors. test_runner Issues and PRs related to the test runner subsystem.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants