Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test test-zlib-brotli-16GB #51772

Closed
targos opened this issue Feb 15, 2024 · 4 comments · Fixed by #51792
Closed

Flaky test test-zlib-brotli-16GB #51772

targos opened this issue Feb 15, 2024 · 4 comments · Fixed by #51792
Labels
aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. linux Issues and PRs related to the Linux platform.

Comments

@targos
Copy link
Member

targos commented Feb 15, 2024

Test

test/parallel/test-zlib-brotli-16GB.js

Platform

AIX

Console output

17:07:37 not ok 3588 parallel/test-zlib-brotli-16GB
17:07:37   ---
17:07:37   duration_ms: 412.84800
17:07:37   severity: fail
17:07:37   exitcode: 1
17:07:37   stack: |-
17:07:37     node:assert:126
17:07:37       throw new AssertionError(obj);
17:07:37       ^
17:07:37     
17:07:37     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
17:07:37     
17:07:37     0 !== 1
17:07:37     
17:07:37         at Timeout.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/parallel/test-zlib-brotli-16GB.js:21:3)
17:07:37         at Timeout._onTimeout (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/common/index.js:476:15)
17:07:37         at listOnTimeout (node:internal/timers:573:17)
17:07:37         at process.processTimers (node:internal/timers:514:7) {
17:07:37       generatedMessage: true,
17:07:37       code: 'ERR_ASSERTION',
17:07:37       actual: 0,
17:07:37       expected: 1,
17:07:37       operator: 'strictEqual'
17:07:37     }
17:07:37     
17:07:37     Node.js v21.6.3-pre
17:07:37   ...

Build links

Additional information

No response

@targos targos added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Feb 15, 2024
@github-actions github-actions bot added the aix Issues and PRs related to the AIX platform. label Feb 15, 2024
@richardlau
Copy link
Member

Failed in https://ci.nodejs.org/job/node-test-commit-linux-containered/41606/nodes=ubuntu2204_sharedlibs_icu_x64/ as well.

https://ci.nodejs.org/job/node-test-commit-linux-containered/41606/nodes=ubuntu2204_sharedlibs_icu_x64/console

12:03:15 not ok 3348 parallel/test-zlib-brotli-16GB
12:03:15   ---
12:03:15   duration_ms: 623.88700
12:03:15   severity: fail
12:03:15   exitcode: 1
12:03:15   stack: |-
12:03:15     node:assert:126
12:03:15       throw new AssertionError(obj);
12:03:15       ^
12:03:15     
12:03:15     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
12:03:15     
12:03:15     0 !== 1
12:03:15     
12:03:15         at Timeout.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-zlib-brotli-16GB.js:21:3)
12:03:15         at Timeout._onTimeout (/home/iojs/build/workspace/node-test-commit-linux-containered/test/common/index.js:473:15)
12:03:15         at listOnTimeout (node:internal/timers:573:17)
12:03:15         at process.processTimers (node:internal/timers:514:7) {
12:03:15       generatedMessage: true,
12:03:15       code: 'ERR_ASSERTION',
12:03:15       actual: 0,
12:03:15       expected: 1,
12:03:15       operator: 'strictEqual'
12:03:15     }
12:03:15     
12:03:15     Node.js v22.0.0-pre
12:03:15   ...

@richardlau richardlau added the linux Issues and PRs related to the Linux platform. label Feb 15, 2024
@targos
Copy link
Member Author

targos commented Feb 16, 2024

@RafaelGSS
Copy link
Member

RafaelGSS commented Feb 17, 2024

So, I've "fixed" it in a single branch (v20 I guess) by increasing the platform timeout to 500

https://github.com/nodejs/node/blob/v20.x/test/parallel/test-zlib-brotli-16GB.js#L22. While this isn't a "fix", we could use until find a better test suite.

@mcollina
Copy link
Member

I'd love a better way to test for this bug :/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. linux Issues and PRs related to the Linux platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants