Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path.relative breaks for paths that differ by trailing separator in v23.0.0 #55424

Closed
vzaidman opened this issue Oct 17, 2024 · 1 comment
Closed
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.

Comments

@vzaidman
Copy link

vzaidman commented Oct 17, 2024

Version

v23.0.0

Platform

23.6.0 Darwin Kernel Version 23.6.0 arm64

What steps will reproduce the bug?

$ nvm use v22.10.0
$ node
> require('path').relative('/root', '/root/')
''

$ nvm use 23 
$ node      
> require('path').relative('/root', '/root/')
'../root/'

How often does it reproduce? Is there a required condition?

Consistent

What is the expected behavior? Why is that the expected behavior?

require('path').relative('/root', '/root/') should return '' like in previous versions of node

What do you see instead?

require('path').relative('/root', '/root/') returns '../root/'

Additional information

Reproduces on Window and Ubuntu.

@vzaidman vzaidman changed the title Path.relative breaks for paths that differ by trailing comma in v23.0.0 Path.relative breaks for paths that differ by trailing separator in v23.0.0 Oct 17, 2024
@avivkeller avivkeller closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
@avivkeller avivkeller added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Oct 17, 2024
@avivkeller
Copy link
Member

Duplicate of #55410
Fixed by #55414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.
Projects
None yet
Development

No branches or pull requests

2 participants