v8_inspector: segfault with simple http request

[bnoordhuis]

gdb

$ gdb --args ./out/Release/node --inspect benchmark/http_simple.js
Reading symbols from ./out/Release/node...done.
(gdb) run
Starting program: /home/bnoordhuis/src/v1.x/out/Release/node --inspect benchmark/http_simple.js
Missing separate debuginfos, use: dnf debuginfo-install glibc-2.23.1-8.fc24.x86_64
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
[New Thread 0x7ffff6b46700 (LWP 30829)]
[New Thread 0x7ffff6345700 (LWP 30830)]
[New Thread 0x7ffff5b44700 (LWP 30831)]
[New Thread 0x7ffff5343700 (LWP 30832)]
[New Thread 0x7ffff4b42700 (LWP 30833)]
Debugger listening on port 9229.
Warning: This is an experimental feature and could change at any time.
To start debugging, open the following URL in Chrome:
    chrome-devtools://devtools/remote/serve_file/@521e5b7e2b7cc66b4006a8a54cb9c4e57494a5ef/inspector.html?experiments=true&v8only=true&ws=localhost:9229/node
Listening at http://127.0.0.1:8000/

Thread 6 "node" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff4b42700 (LWP 30833)]
0x00000000010f504b in dispose_inspector(uv_handle_s*) ()
Missing separate debuginfos, use: dnf debuginfo-install libgcc-6.1.1-2.fc24.x86_64 libstdc++-6.1.1-2.fc24.x86_64
(gdb) bt
#0  0x00000000010f504b in dispose_inspector(uv_handle_s*) ()
#1  0x00000000013074e5 in uv__finish_close (handle=0x7ffff0000d08) at ../deps/uv/src/unix/core.c:272
#2  uv__run_closing_handles (loop=0x1d75ee8) at ../deps/uv/src/unix/core.c:286
#3  uv_run (loop=0x1d75ee8, mode=UV_RUN_DEFAULT) at ../deps/uv/src/unix/core.c:356
#4  0x00000000010f3b84 in node::inspector::AgentImpl::WorkerRunIO() ()
#5  0x0000000001313528 in uv__thread_start (arg=<optimized out>) at ../deps/uv/src/unix/thread.c:52
#6  0x00007ffff6f105ca in start_thread () from /lib64/libpthread.so.0
#7  0x00007ffff6c49ead in clone () from /lib64/libc.so.6

curl:

$ curl -v http://127.0.0.1:9229/
*   Trying 127.0.0.1...
* Connected to 127.0.0.1 (127.0.0.1) port 9229 (#0)
> GET / HTTP/1.1
> Host: 127.0.0.1:9229
> User-Agent: curl/7.47.1
> Accept: */*
>
* HTTP 1.0, assume close after body
< HTTP/1.0 400 Bad Request
< Content-Type: text/html; charset=UTF-8
<

cc @ofrobots @pavelfeldman

[bnoordhuis]

#7490

[ofrobots]

Doesn't this get fixed by #7450?

[eugeneo]

I confirmed with the valgrind that 7450 fixes this problem.

[bnoordhuis]

08aff14 seems to fix it.