Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: fs.mkdtemp to v4.x #7714

Closed
indutny opened this issue Jul 13, 2016 · 11 comments
Closed

Backport: fs.mkdtemp to v4.x #7714

indutny opened this issue Jul 13, 2016 · 11 comments
Labels
fs Issues and PRs related to the fs subsystem / file system. semver-minor PRs that contain new features and should be released in the next minor version.

Comments

@indutny
Copy link
Member

indutny commented Jul 13, 2016

  • Version: v4
  • Platform: OS X
  • Subsystem: fs

I suggest that we should backport fs.mkdtemp to v4 LTS. These are commits that introduced it (and fixed it several times):

cc @nodejs/lts

@indutny indutny added fs Issues and PRs related to the fs subsystem / file system. lts-watch-v4.x labels Jul 13, 2016
@indutny
Copy link
Member Author

indutny commented Jul 13, 2016

cc @Fishrock123

@MylesBorins
Copy link
Contributor

@indutny would this be semver minor?

@indutny
Copy link
Member Author

indutny commented Jul 13, 2016

Yep.

@indutny indutny added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 13, 2016
@MylesBorins
Copy link
Contributor

@nodejs/lts what do people think about this? If we can get decent consensus we may be able to avoid having to do this in an official meeting

@rvagg
Copy link
Member

rvagg commented Jul 14, 2016

@indutny why? can you help us justify why this is important enough? We were just yesterday discussing how v4.5 may be our last semver-minor bump on v4. We still have time left on Active LTS so it's not out of the question but we need pretty strong justification for each semver-minor I think.

@indutny
Copy link
Member Author

indutny commented Jul 14, 2016

@rvagg this is not necessary, but it is hard to see why it hasn't been done before. This API was provided by libuv since the initial release of v4, so there is no reason to not expose it.

Right now, I had to disable v4 on travis tests for some of my modules that use this.

@rvagg
Copy link
Member

rvagg commented Jul 14, 2016

OK, worth a discussion anyway, as I said in nodejs/Release#121 I don't think we even now have a clear idea of what the rules are for what gets into LTS, I was hoping for principles to emerge a bit quicker than this through what we've been doing but that hasn't been the case.

@ChALkeR
Copy link
Member

ChALkeR commented Jul 14, 2016

Hm. This change (with all the commits merged) looks purely additive and rather small.
The actual change looks good.

The timing is bad, though — 4.5.0-rc.1 is already out. Is this targeted to 4.6?

@indutny
Copy link
Member Author

indutny commented Jul 15, 2016

@ChALkeR this is just a suggestion, there is no decision on target version.

@jasnell
Copy link
Member

jasnell commented Aug 8, 2016

The @nodejs/lts WG discussed the possibility of backporting this to v4.x and decided against it due to lack of a pressing justification.

@jasnell
Copy link
Member

jasnell commented Aug 9, 2016

@indutny ... going to go ahead and close this given the LTS discussion yesterday. Can revisit if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

No branches or pull requests

5 participants