-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No callbacks when closing sockets #7916
Comments
Could you create a testcase that does not require any thirdparty modules? |
Just tested following code on all major versions of Node.js from old var dgram = require('dgram');
var server = dgram.createSocket('udp4');
server.on('listening', function () {
var address = server.address();
console.log('server listening: ' + address.address + ':' + address.port);
});
server.on('close', function () {
console.log('server closed (event)');
});
server.bind(41234);
setTimeout(function () {
server.close( function() {
console.log('server closed (callback)');
});
}, 1000); Output with Node.js version >= 4: $ node dgram_test.js
server listening: 0.0.0.0:41234
server closed (event)
server closed (callback) Output with Node.js version <= 0.12: $ node dgram_test.js
server listening: 0.0.0.0:41234
server closed (event) This expected behaviour matches the API documentation for each version: https://nodejs.org/docs/latest-v0.12.x/api/dgram.html#dgram_socket_close I think this issue can be closed. |
This ticket
Ticket you linked to:
@svencan Are you sure that you are running Node.js 6.3.1? |
Ok, no way to reproduce atm, not clear what the actual issue is, and the description mentions that JXCore is being used instead of Node.js. I'm closing this for now, feel free to reopen if it is an issue that could be reproduced in recent Node.js versions. |
I think the following issue is dgram related, not node-upnp-utils related.
futomi/node-upnp-utils#1
The text was updated successfully, but these errors were encountered: