Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: compare.R script does not work with --runs 1 #8288

Closed
mscdex opened this issue Aug 26, 2016 · 3 comments
Closed

benchmark: compare.R script does not work with --runs 1 #8288

mscdex opened this issue Aug 26, 2016 · 3 comments
Labels
benchmark Issues and PRs related to the benchmark subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Aug 26, 2016

  • Version: master
  • Platform: Linux
  • Subsystem: benchmark

The benchmark/compare.R script does not seem to work with output from compare.js with --runs 1:

Error in t.test.default(x = 15468.63, y = 15982.13) : 
  not enough 'x' observations
Calls: ddply ... t.test.formula -> do.call -> t.test -> t.test.default
Execution halted

/cc @AndreasMadsen
@mscdex mscdex added the benchmark Issues and PRs related to the benchmark subsystem. label Aug 26, 2016
@AndreasMadsen
Copy link
Member

AndreasMadsen commented Aug 27, 2016 •
edited
Loading

The problem is that you can't calculate the standard deviation with just one observation. We can either print a better error or skip the significance calculation.

@mscdex
Copy link
Contributor Author

mscdex commented Aug 27, 2016

+1 to just skipping the significance calculation

@AndreasMadsen AndreasMadsen mentioned this issue Aug 27, 2016
Closed
1 task
@AndreasMadsen
Copy link
Member

"fixed" in: #8299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @AndreasMadsen