-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: install header files required for compiled addons #859
Comments
|
+1 |
1 similar comment
👍 |
I can do it myself, but this is also a reasonably simple patch that can be implemented by another contributor. |
Forgive me if this is a naïve question, but does this basically involve opening |
@piscisaureus @nodejs/build Should this remain open? |
I think this can be closed in favour of nodejs/node-gyp#1247, if we embed the headers in the binary then there's no need to have them separately in the installer. |
OK, closing, but feel free to re-open etc. etc. etc. |
but the "embed the headers in the binary" should be a node core issue... |
I have it in my backlog. |
Some of this conversation must have leaked into my subconscious, since two ideas came to me in a dream last night:
|
The windows installer should install header files. If we do this node-gyp wouldn't have to download a tarball to get the headers.
I would suggest to install them into
program files\iojs\include
.The text was updated successfully, but these errors were encountered: