-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release proposal: v1.4.0 #932
Comments
It'd be mighty swell to land #758 now that bnoordhuis and trevnorris LGTM'd it :D |
And #847 ;-) |
yes, it would be nice to land both of them, and others.. I'd like #894 to be fixed for instance. But, we need to set and maintain a more rapid release cycle and avoid the mindset that releases should be held up to get particular things in--both for the sake of getting a release out and for the sake of making sure we take care before merging things that probably need further discussion. Just remember that it'll likely be under a week after merging that your favourite pull request is finally merged, this ain't no 0.12. |
This all LGTM. |
LGTM. |
+1 |
1 similar comment
+1 |
aaaactually, npm@2.6.0 is a minor version bump, does anybody have objections to bumping minor when npm bumps minor? see discussion @ #904 (comment) @iojs/tc that would make this 1.4.0 |
@indutny sounds like you have a LGTM from Chris so go for it, just make sure you tag it if it's supposed to be semver-minor, we're programatically relying on those tags now |
@rvagg there is also a security update in libuv that will happen today. |
updated original description with newer changelog including SEMVER-MINOR tag for npm |
As per discussion in #904, i'm not convinced this should be semver-minor as it currently stands. |
@Fishrock123 semver-major? |
LGTM. I don't think the npm upgrade merits bumping the minor, for the reasons outlined in #904. |
It doesn't but JSStream thing most likely does. |
@rvagg libuv/libuv@e19089f , libuv will be released soon. |
@rvagg please update to libuv 1.4.1 before the release. |
I'll send a PR with the update. |
:-) We should coordinate that somehow... |
Sorry, I didn't want to flood your inbox. I'll cc you next time. |
No worries Ben, and thanks! |
@rvagg I've amended the docs PR based on domenic's and sam's criticism and comments :) |
Yes, the build machines have inconsistent git tree now anyway so to be sure we'll do 1.4.1. |
1.4.2 is out now. @bnoordhuis can you make the libuv update PR? |
For future releases: how about setting a proposed release date so everyone know what timespan is expected for feedback? I guess the date/time would be relative to how "major" a release would be; spanning days, weeks or just hours. |
@jbergstroem seems to be hard to predict, assuming that we don't have "definite" roadmap at this point. |
@indutny hard to predict: valid point -- but suggesting a release date at the same time a changelog is posted gives a pretty good indication in terms of expected feedback. For reference, @rvagg suggested a release "within a day or two" three days ago. If that was a set date people might have acted differently. |
Aaah, I thought you was talking about release dates in general. Ok, then. |
@indutny Ah, not at all. In time, using milestones or whatnot is probably great. For now, it's not helping anyone. |
2015-02-26, Version 1.4.1, @rvaggNote: version 1.4.0 was tagged and built but not released. A libuv bug was discovered in the process so the release was aborted. The tag was straight after Notable changes
Known issues
Commits |
nightly / RC: https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/92/ should be at https://iojs.org/download/nightly/v1.3.1-nightly201502262e2cf81476/ within 15 minutes or so, would appreciate testers before we release |
release build for v1.4.1 @ https://jenkins-iojs.nodesource.com/job/iojs+release/28/ |
Why is the iojs-win2008r2-release-x64 build running from v1.4.0 instead of
v1.4.1? I'm looking at
https://jenkins-iojs.nodesource.com/job/iojs+release/28/ which links to
https://jenkins-iojs.nodesource.com/job/iojs+release/28/nodes=iojs-win2008r2-release-x64/
|
take 2, problem with one of the windows build machines, crossing fingers it'll be taken care of automatically: https://jenkins-iojs.nodesource.com/job/iojs+release/29/ |
You're right @mzgol thanks for pointing that out. I'm going to get in to that machine and clean it out, that's not right.. Another reason we need to wean our way off Jenkins eventually. |
problem on build machines is related to the aborted commit and my force push + delete of the 1.4.0 tag. I've set up the release job to clean & force a fresh clone before building, which is probably the best way to do release builds anyway. Looking good now @ https://jenkins-iojs.nodesource.com/job/iojs+release/31/ ARMv6 pending |
nope, something still borked on the git end, shaving yaks, send help if I'm not back soon |
@rvagg Bad news, this is happening again: |
I believe I finally have it sorted .. 2 hours later .. https://jenkins-iojs.nodesource.com/job/iojs+release/41/ |
just testing the builds before release, I don't have a high degree of trust at the moment thanks to Jenkins |
all done & released, https://iojs.org/dist/latest/ has v1.4.1 ping @iojs/website |
Noted. |
Nice work @rvagg :) |
V8 has been back to 4.1.0.16, why still write 4.1.0.21 in changelog? |
@popomore What do you mean?
|
Maybe I misunderstood the message from the commit bnoordhuis@a558cd0 |
Ah, the 'backs out' refers to the change from the 4.1.0.16 release. That commit is essentially an upgrade to 4.1.0.21 minus the change that prompted the 4.1.0.16 release. |
Can anybody see a semver-major in here that's not properly tagged? If not, let's go and get a patch release out within the next day or two.
8a1e22af3a
] - benchmark: pass execArgv to the benchmarking process (Petka Antonov) #928234e6916b8
] - build: Fix incorrect reference (Johan Bergström) #924e00c938d24
] - build: make test-ci output TAP to stdout and log (Rod Vagg) #938b2a0d8f65e
] - deps: update libuv to 1.4.2 (Ben Noordhuis) #966a558cd0a61
] - deps: revert v8 abi change (Ben Noordhuis) #95254532a9761
] - deps: fix postmortem support in v8 (Fedor Indutny) #70678f4837926
] - deps: upgrade v8 to 4.1.0.21 (Ben Noordhuis) #952739fda16a9
] - deps: update libuv to 1.4.1 (Ben Noordhuis) #940da730c76e9
] - deps: enable node-gyp iojs.lib download checksum (Ben Noordhuis) #91897b424365a
] - deps: make node-gyp work again on windows (Bert Belder)19e3d5e10a
] - deps: make node-gyp fetch tarballs from iojs.org (Ben Noordhuis) #3431e2fa1537f
] - deps: upgrade npm to 2.6.0 (Forrest L Norvell) #9042e63bad7eb
] - doc: link & formatting of SHAs in commit list (Tim Oxley) #967c5050d8e4d
] - doc: fix 'dhparam' description of tls.createServer (silverwind) #96806ee782f24
] - doc: document 'unhandledRejection' and 'rejectionHandled' (Benjamin Gruenbaum) #946b65dade102
] - doc: update documentation.markdown for io.js. (Ryan Scheel) #95087e4bfd582
] - doc: link cluster worker.send() to child.send() (Sam Roberts) #839cb22bc9b8a
] - doc: fix footer sizing (Jeremiah Senkpiel) #8603ab9b92e90
] - doc: fix stream_writev
header size (René Kooi) #9164fcbb8aaaf
] - doc: use HTTPS URL for the API documentation page (Shinnosuke Watanabe) #913329f364ea2
] - doc: fix PR reference in CHANGELOG (Brian White) #9030ac57317aa
] - doc: fix typo, rephrase cipher change in CHANGELOG (Rod Vagg) #9021f40b2a636
] - fs: add type checking to makeCallback() (cjihrig) #866c82e580a50
] - fs: properly handle fd passed to truncate() (Bruno Jouhier) joyent/node#91612ca22aacbd
] - (SEMVER-MINOR) http: emit abort event from ClientRequest (Evan Lucas) #945d8eb974a98
] - net: make Server.prototype.unref() persistent (cjihrig) #897872702d9b7
] - (SEMVER-MINOR) node: implement unhandled rejection tracking (Petka Antonov) #758b41dbc2737
] - readline: use nativecodePointAt
(Vladimir Kurchatkin) #82526ebe9805e
] - smalloc: extend user API (Trevor Norris) #905e435a0114d
] - src: fix intermittent SIGSEGV in resolveTxt (Evan Lucas) #9600af4c9ea74
] - src: fix domains + --abort-on-uncaught-exception (Chris Dickinson) #92289e133a1d8
] - stream_base: remove static JSMethod declarations (Fedor Indutny) #957b9686233fc
] - stream_base: introduce StreamBase (Fedor Indutny) #8401738c77835
] - (SEMVER-MINOR) streams: introduce StreamWrap and JSStream (Fedor Indutny) #926506c7fd40b
] - test: fix infinite spawn cycle in stdio test (Ben Noordhuis) #948a7bdce249c
] - test: support writing test output to file (Johan Bergström) #9340df54303c1
] - test: common.js -> common (Brendan Ashworth) #917ed3b057e9f
] - util: handle symbols properly in format() (cjihrig) #931The text was updated successfully, but these errors were encountered: