Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: doc/api/modules.md needs a better explanation of exports #9840

Closed
Trott opened this issue Nov 29, 2016 · 3 comments
Closed

doc: doc/api/modules.md needs a better explanation of exports #9840

Trott opened this issue Nov 29, 2016 · 3 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. module Issues and PRs related to the module subsystem.

Comments

@Trott
Copy link
Member

Trott commented Nov 29, 2016

  • Version: v8.0.0-pre
  • Platform: all
  • Subsystem: doc

The Modules doc needs a better explanation of the utility of exports vs. module.exports. If that's too much detail for the API doc, then perhaps we can write a guide in doc/guides and link to it.
@Trott Trott added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. module Issues and PRs related to the module subsystem. labels Nov 29, 2016
@sam-github
Copy link
Contributor

@Trott #9622 (waiting @jasnell to clear his changes requested state)

@wademauger
Copy link

Is this still an open issue, now that #9622 is merged? @sam-github

@Trott
Copy link
Member Author

Trott commented Dec 25, 2016

Is this still an open issue, now that #9622 is merged? @sam-github

I'd say we can close this and open a new issue if there are specific deficiencies in the current doc that should be addressed.

@Trott Trott closed this as completed Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sam-github @Trott @wademauger