From f640fc8e3d6d509f2b6322762e5f6deed197082f Mon Sep 17 00:00:00 2001 From: John Barboza Date: Wed, 7 Dec 2016 15:44:14 -0500 Subject: [PATCH 1/2] deps: define missing operator delete functions Section 3.2 of the C++ standard states that destructor definitions implicitly "use" operator delete functions. Therefore, these operator delete functions must be defined even if they are never called by user code explicitly. http://www.open-std.org/JTC1/SC22/WG21/docs/cwg_defects.html#261 gcc allows them to remain as empty definitions. However, not all compilers allow this. This pull request creates definitions which if ever called, result in an abort. --- deps/v8/src/api.cc | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/deps/v8/src/api.cc b/deps/v8/src/api.cc index 9aa877cf4408c0..3ff34f9b6f79bf 100644 --- a/deps/v8/src/api.cc +++ b/deps/v8/src/api.cc @@ -598,6 +598,11 @@ HandleScope::~HandleScope() { } +void HandleScope::operator delete(void*, size_t) { + base::OS::Abort(); +} + + int HandleScope::NumberOfHandles(Isolate* isolate) { return i::HandleScope::NumberOfHandles( reinterpret_cast(isolate)); @@ -623,6 +628,11 @@ EscapableHandleScope::EscapableHandleScope(Isolate* v8_isolate) { } +void EscapableHandleScope::operator delete(void*, size_t) { + base::OS::Abort(); +} + + i::Object** EscapableHandleScope::Escape(i::Object** escape_value) { i::Heap* heap = reinterpret_cast(GetIsolate())->heap(); Utils::ApiCheck(*escape_slot_ == heap->the_hole_value(), @@ -658,6 +668,11 @@ SealHandleScope::~SealHandleScope() { } +void SealHandleScope::operator delete(void*, size_t) { + base::OS::Abort(); +} + + void Context::Enter() { i::Handle env = Utils::OpenHandle(this); i::Isolate* isolate = env->GetIsolate(); @@ -1884,6 +1899,11 @@ v8::TryCatch::~TryCatch() { } +void v8::TryCatch::operator delete(void*, size_t) { + base::OS::Abort(); +} + + bool v8::TryCatch::HasCaught() const { return !reinterpret_cast(exception_)->IsTheHole(); } @@ -6449,6 +6469,11 @@ void Isolate::RemoveGCEpilogueCallback(GCEpilogueCallback callback) { } +void Isolate::operator delete(void*, size_t) { + base::OS::Abort(); +} + + void V8::AddGCPrologueCallback(GCPrologueCallback callback, GCType gc_type) { i::Isolate* isolate = i::Isolate::Current(); isolate->heap()->AddGCPrologueCallback( From 40f226225f2d92bb2802a98bf14cbad3437474d7 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 21 Dec 2016 12:55:45 +0100 Subject: [PATCH 2/2] [squash] bump V8 patchlevel --- deps/v8/src/version.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/v8/src/version.cc b/deps/v8/src/version.cc index 28b9de3a7a9804..3da364cf9c1a72 100644 --- a/deps/v8/src/version.cc +++ b/deps/v8/src/version.cc @@ -35,7 +35,7 @@ #define MAJOR_VERSION 3 #define MINOR_VERSION 28 #define BUILD_NUMBER 71 -#define PATCH_LEVEL 19 +#define PATCH_LEVEL 20 // Use 1 for candidates and 0 otherwise. // (Boolean macro values are not supported by all preprocessors.) #define IS_CANDIDATE_VERSION 0