Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade npm to 2.15.12 #12479

Closed
wants to merge 7 commits into from
Closed

upgrade npm to 2.15.12 #12479

wants to merge 7 commits into from

Conversation

iarna
Copy link
Member

@iarna iarna commented Apr 18, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of change

This release ONLY bumps the version of node-gyp to 3.6.0.

Changelogs

r: @Fishrock123
r: @addaleax
r: @jasnell

lekoder and others added 6 commits April 17, 2017 18:33
@lekoder @MylesBorins
tls: TLSSocket emits 'error' on handshake failure
33a4fc6 
Removes branch that would make TLSSocket emit '_tlsError' event if
error occured on handshake and control was not released, as it was
never happening.  Added test for tls.Server to ensure it still emits
'tlsClientError' as expected.

Note that 'tlsClientError' does not exist in the v4.x branch so this
back-port emits 'clientError' instead.  See also pull request nodejs#4557.

Fixes: nodejs#8803
PR-URL: nodejs#8805
Refs: nodejs#4557
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@mhdawson @MylesBorins
doc: add supported platforms list
1546863 
Original Commit Message:
  PR-URL: nodejs#11872
  Reviewed-By: James M Snell <jasnell@gmail.com>
  Reviewed-By: Rich Trott <rtrott@gmail.com>
  Reviewed-By: Roman Reiss <me@silverwind.io>
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Backport-Of: nodejs#11872
PR-URL: nodejs#11943
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson @MylesBorins
doc: add supported platforms list for v6.x
596027c 
Original Commit Message:
  PR-URL: nodejs#11943
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-Of: nodejs#11943
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: JoãReis <reis@janeasystems.com>
Reviewed-By: Johan Bergströbugs@bergstroem.nu>
@mhdawson @MylesBorins
doc: add supported platforms list for v4.x
b83b043 
PR-URL: nodejs#12091
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: JoãReis <reis@janeasystems.com>
Reviewed-By: Johan Bergströbugs@bergstroem.nu>
@richardlau @MylesBorins
test: add test for loading from global folders
4791549 
Test executes with a copy of the node executable since $PREFIX/lib/node
is relative to the executable location.

PR-URL: nodejs#9283
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@richardlau @MylesBorins
module: fix loading from global folders on Windows
8db3cb4 
Code was calculating $PREFIX/lib/node relative to process.execPath, but
on Windows process.execPath is $PREFIX\node.exe whereas everywhere else
process.execPath is $PREFIX/bin/node (where $PREFIX is the root of the
installed Node.js).

PR-URL: nodejs#9283
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@iarna iarna added dont-land-on-v6.x npm Issues and PRs related to the npm client dependency or the npm registry. labels Apr 18, 2017
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. npm Issues and PRs related to the npm client dependency or the npm registry. v4.x labels Apr 18, 2017
watilde
watilde reviewed Apr 18, 2017
View reviewed changes
deps/npm/html/doc/misc/npm-index.html
@@ -1,245 +0,0 @@
<!doctype html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to keep this file.

@addaleax
Copy link
Member

Fwiw node-gyp 3.6.0 is known to have a regression, see nodejs/node-gyp#1153 … I only know about this because this was reported against one of my own packages, so I can’t estimate the overall impact, but I’d prefer to have node ship with a version of node-gyp where that’s fixed

@gibfahn
Copy link
Member

gibfahn commented Apr 20, 2017

but I’d prefer to have node ship with a version of node-gyp where that’s fixed

Agreed, but if we can't have node-gyp 3.6.0 and v4.x is about to go into maintenance, could we at least get 3.5.0? We're currently on 3.4.0 and I'd really like --devdir supported across v4.x and v6.x (Note that v6.x is also currently on 3.4.0).

@jasnell
Copy link
Member

jasnell commented Apr 20, 2017

Quick note: v4.x is not about to go into maintenance, it is in maintenance as of April 1st.

@MylesBorins
Copy link
Contributor

I'm open to landing a new npm to v4.x if it has a version of node-gyp that is stable

@addaleax addaleax mentioned this pull request Apr 30, 2017
Closed
4 tasks
@BridgeAR
Copy link
Member

How should we progress here?

@watilde
Copy link
Contributor

watilde commented Aug 26, 2017

I think we still need to bump the version of node-gyp at npm@2 and then we can remake PR.

@jasnell
Copy link
Member

jasnell commented Aug 29, 2017

Ping @nodejs/lts

@richardlau
Copy link
Member

@refack Is node-gyp 3.6.0 the desired version, or do we need another bump in npm@2?

@refack
Copy link
Contributor

refack commented Sep 6, 2017

@richardlau thanks. The current recommended version of node-gyp is 3.6.2. It has several bug fixes for Windows users.

@MylesBorins
Copy link
Contributor

@iarna would it be possible to get a release that bumps to 3.6.2

@BridgeAR
Copy link
Member

Ping @iarna @zkat

@BridgeAR
Copy link
Member

BridgeAR commented Oct 2, 2017

Ping @nodejs/npm @zkat again

@watilde watilde mentioned this pull request Oct 10, 2017
Closed
@BridgeAR
Copy link
Member

Closing due to long inactivity and no response from @iarna or @zkat

If someone feels like this should stay open, please reopen.

@BridgeAR BridgeAR closed this Nov 22, 2017
@baby636 baby636 mentioned this pull request Jun 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watilde watilde watilde left review comments

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.