From ae5274938ffd59d4bf15e6818f4d33e638eb0060 Mon Sep 17 00:00:00 2001 From: Patrick Heneise Date: Mon, 6 Nov 2017 15:39:20 +0000 Subject: [PATCH 1/4] test: fs.write() if 3rd argument is a callback, not offset --- test/parallel/test-fs-write.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/test/parallel/test-fs-write.js b/test/parallel/test-fs-write.js index fd0e6b768da042..27783f552db1bc 100644 --- a/test/parallel/test-fs-write.js +++ b/test/parallel/test-fs-write.js @@ -70,3 +70,14 @@ fs.open(fn2, constants.O_CREAT | constants.O_WRONLY | constants.O_TRUNC, 0o644, assert.strictEqual(expected, found); })); })); + + +fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) { + assert.ifError(err); + console.log('open done'); + const done = common.mustCall(function(err, written) { + assert.strictEqual(Buffer.byteLength(expected), written); + fs.closeSync(fd); + }); + fs.write(fd, expected, done); +})); \ No newline at end of file From e901ee98dcddcd0995d705d8d372f41b23b0a31a Mon Sep 17 00:00:00 2001 From: Patrick Heneise Date: Mon, 6 Nov 2017 15:42:02 +0000 Subject: [PATCH 2/4] lint: newline eof --- test/parallel/test-fs-write.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-fs-write.js b/test/parallel/test-fs-write.js index 27783f552db1bc..6cc681ab8a08c7 100644 --- a/test/parallel/test-fs-write.js +++ b/test/parallel/test-fs-write.js @@ -80,4 +80,4 @@ fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) { fs.closeSync(fd); }); fs.write(fd, expected, done); -})); \ No newline at end of file +})); From 7d7d9a964ad6af0476c04ee75cd4fe597afdb852 Mon Sep 17 00:00:00 2001 From: Patrick Heneise Date: Mon, 6 Nov 2017 16:05:37 +0000 Subject: [PATCH 3/4] remove console.log --- test/parallel/test-fs-write.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/parallel/test-fs-write.js b/test/parallel/test-fs-write.js index 6cc681ab8a08c7..3447204a3a0763 100644 --- a/test/parallel/test-fs-write.js +++ b/test/parallel/test-fs-write.js @@ -74,7 +74,6 @@ fs.open(fn2, constants.O_CREAT | constants.O_WRONLY | constants.O_TRUNC, 0o644, fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) { assert.ifError(err); - console.log('open done'); const done = common.mustCall(function(err, written) { assert.strictEqual(Buffer.byteLength(expected), written); fs.closeSync(fd); From de5febc91afeb31d79fb7d24a44aae8e51e903e9 Mon Sep 17 00:00:00 2001 From: Patrick Heneise Date: Tue, 7 Nov 2017 09:39:29 +0000 Subject: [PATCH 4/4] add assert.ifError() --- test/parallel/test-fs-write.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/parallel/test-fs-write.js b/test/parallel/test-fs-write.js index 3447204a3a0763..cd6dc9843222ad 100644 --- a/test/parallel/test-fs-write.js +++ b/test/parallel/test-fs-write.js @@ -75,6 +75,7 @@ fs.open(fn2, constants.O_CREAT | constants.O_WRONLY | constants.O_TRUNC, 0o644, fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) { assert.ifError(err); const done = common.mustCall(function(err, written) { + assert.ifError(err); assert.strictEqual(Buffer.byteLength(expected), written); fs.closeSync(fd); });