From b48f94aede413b459a1cdddb2e8fb9605d46f4c8 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 4 Jan 2018 15:37:53 -0800 Subject: [PATCH 1/5] doc: remove spaces around slash in BUILDING.md --- BUILDING.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index c459a867ba6096..6b28317e70162b 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -10,7 +10,7 @@ file a new issue. ## Supported platforms -This list of supported platforms is current as of the branch / release to +This list of supported platforms is current as of the branch/release to which it is attached. ### Input @@ -41,7 +41,7 @@ in production. |--------------|--------------|----------------------------------|----------------------|------------------| | GNU/Linux | Tier 1 | kernel >= 2.6.32, glibc >= 2.12 | x64, arm, arm64 | | | macOS | Tier 1 | >= 10.10 | x64 | | -| Windows | Tier 1 | >= Windows 7 / 2008 R2 | x86, x64 | vs2017 | +| Windows | Tier 1 | >= Windows 7/2008 R2 | x86, x64 | vs2017 | | SmartOS | Tier 2 | >= 15 < 16.4 | x86, x64 | see note1 | | FreeBSD | Tier 2 | >= 10 | x64 | | | GNU/Linux | Tier 2 | kernel >= 3.13.0, glibc >= 2.19 | ppc64le >=power8 | | @@ -92,7 +92,7 @@ Depending on host platform, the selection of toolchains may vary. *Note:* All prerequisites can be easily installed by following [this bootstrapping guide](https://github.com/nodejs/node/blob/master/tools/bootstrap/README.md). -### Unix / macOS +### Unix/macOS Prerequisites: @@ -233,7 +233,7 @@ To test if Node.js was built correctly: > Release\node -e "console.log('Hello from Node.js', process.version)" ``` -### Android / Android-based devices (e.g. Firefox OS) +### Android/Android-based devices (e.g. Firefox OS) Although these instructions for building on Android are provided, please note that Android is not an officially supported platform at this time. Patches to @@ -273,7 +273,7 @@ With the `--download=all`, this may download ICU if you don't have an ICU in `deps/icu`. (The embedded `small-icu` included in the default Node.js source does not include all locales.) -##### Unix / macOS: +##### Unix/macOS: ```console $ ./configure --with-intl=full-icu --download=all @@ -290,7 +290,7 @@ $ ./configure --with-intl=full-icu --download=all The `Intl` object will not be available, nor some other APIs such as `String.normalize`. -##### Unix / macOS: +##### Unix/macOS: ```console $ ./configure --without-intl @@ -302,7 +302,7 @@ $ ./configure --without-intl > .\vcbuild without-intl ``` -#### Use existing installed ICU (Unix / macOS only): +#### Use existing installed ICU (Unix/macOS only): ```console $ pkg-config --modversion icu-i18n && ./configure --with-intl=system-icu @@ -318,7 +318,7 @@ You can find other ICU releases at Download the file named something like `icu4c-**##.#**-src.tgz` (or `.zip`). -##### Unix / macOS +##### Unix/macOS From an already-unpacked ICU: ```console From 94c42fd1a626d5534ce5fcfc32c8d0eb167718bd Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 4 Jan 2018 15:40:03 -0800 Subject: [PATCH 2/5] doc: hyphenate _end-of-life_ in BUILDING.md --- BUILDING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 6b28317e70162b..4dbcd1e7a70d93 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -33,8 +33,8 @@ Support is divided into three tiers: ### Supported platforms -The community does not build or test against end of life distributions (EoL). -Thus we do not recommend that you use Node on end of life or unsupported platforms +The community does not build or test against end-of-life distributions (EoL). +Thus we do not recommend that you use Node on end-of-life or unsupported platforms in production. | System | Support type | Version | Architectures | Notes | From 68350c49651d3b055a31a6f9e390e691a8a28a6f Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 4 Jan 2018 15:41:12 -0800 Subject: [PATCH 3/5] doc: add missing comma in BUILDING.md --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index 4dbcd1e7a70d93..59602b6209ae31 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -101,7 +101,7 @@ Prerequisites: * Python 2.6 or 2.7 * GNU Make 3.81 or newer -On macOS you will need to install the `Xcode Command Line Tools` by running +On macOS, you will need to install the `Xcode Command Line Tools` by running `xcode-select --install`. Alternatively, if you already have the full Xcode installed, you can find them under the menu `Xcode -> Open Developer Tool -> More Developer Tools...`. This step will install `clang`, `clang++`, and From 566b59617631d46606d0887496c0a9a0c625297b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 4 Jan 2018 15:41:28 -0800 Subject: [PATCH 4/5] doc: add missing backticks in BUILDING.md --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index 59602b6209ae31..ff79919f5cd4e7 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -114,7 +114,7 @@ If the path to your build directory contains a space, the build will likely fail ```console $ sudo ./tools/macosx-firewall.sh ``` -Running this script will add rules for the executable `node` in the out +Running this script will add rules for the executable `node` in the `out` directory and the symbolic `node` link in the project's root directory. On FreeBSD and OpenBSD, you may also need: From 23c299fabfd1d87b86c30ebe2a408adcdcfee96f Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 4 Jan 2018 15:43:35 -0800 Subject: [PATCH 5/5] doc: add missing comma to BUILDING.md --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index ff79919f5cd4e7..fbf6b9cd9641e2 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -366,7 +366,7 @@ and [user guide](https://openssl.org/docs/fips/UserGuide-2.0.pdf). through which you get the file complies with the requirements for a "secure installation" as described in section 6.6 in the [user guide](https://openssl.org/docs/fips/UserGuide-2.0.pdf). - For evaluation/experimentation you can simply download and verify + For evaluation/experimentation, you can simply download and verify `openssl-fips-x.x.x.tar.gz` from https://www.openssl.org/source/ 2. Extract source to `openssl-fips` folder and `cd openssl-fips` 3. `./config`