src: add ERR_* helpers in C++ and migrates toString() errors in string_bytes.cc #19739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
cc @addaleax |
joyeecheung
added
the
semver-major
devsnek
approved these changes
Apr 2, 2018
jasnell
approved these changes
Apr 2, 2018
addaleax
approved these changes
Apr 2, 2018
src/node_errors.h
Outdated
| v8::Local<v8::Object> e = \ | ||
| v8::Exception::type(js_msg)->ToObject( \ | ||
| isolate->GetCurrentContext()).ToLocalChecked(); \ | ||
| e->Set(OneByteString(isolate, "code"), js_code); \ |
There was a problem hiding this comment.
This should also be the overload that takes a context argument :)
joyeecheung
force-pushed
the
tostring-err
branch
from
9dd0222
to
76cc6dc
Compare
|
Replace the deprecated API with the one that takes the context per suggestion by @addaleax , thanks! |
|
Looks like on Linux PPCBE we need to ensure an extra copy of memory available for reordering..fixed the test. EDIT: the usage of |
joyeecheung
force-pushed
the
tostring-err
branch
2 times, most recently
from
a9fc7b5
to
b416589
Compare
4 tasks
joyeecheung
force-pushed
the
tostring-err
branch
from
b416589
to
36b46a2
Compare
joyeecheung
added a commit
that referenced
this pull request
Apr 7, 2018
Currently calling StringBytes::Encode on a UCS2 buffer results in two copies of the buffer and the usage of std::vector::assign makes the memory usage unpredictable, and therefore hard to test against. This patch makes the memory usage more predictable by allocating the memory using node::UncheckedMalloc and handles the memory allocation failure properly. Only one copy of the buffer will be created and it will be freed upon GC of the string. PR-URL: #19798 Refs: #19739 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit adds node::ERR_*(isolate, message) helpers in the C++ land to assign error codes to existing C++ errors. The following errors are added: - ERR_MEMORY_ALLOCATION_FAILED - ERR_STRING_TOO_LARGE
joyeecheung
force-pushed
the
tostring-err
branch
from
36b46a2
to
6294175
Compare
|
Landed in 1f29963...63eb267, thanks! |
joyeecheung
added a commit
that referenced
this pull request
Apr 7, 2018
This commit adds node::ERR_*(isolate, message) helpers in the C++ land to assign error codes to existing C++ errors. The following errors are added: - ERR_MEMORY_ALLOCATION_FAILED - ERR_STRING_TOO_LARGE PR-URL: #19739 Fixes: #3175 Fixes: #9489 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
4 tasks
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 9, 2018
The old error name and message were trying to be consistent with ERR_BUFFER_TOO_LARGE but they were not really accurate. The kStringMaxLength was measured in number of characters, not number of bytes. The name ERR_STRING_TOO_LARGE also seems a bit awkward. This patch tries to correct them before they get released to users. PR-URL: nodejs#19864 Refs: nodejs#19739 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
Currently calling StringBytes::Encode on a UCS2 buffer results in two copies of the buffer and the usage of std::vector::assign makes the memory usage unpredictable, and therefore hard to test against. This patch makes the memory usage more predictable by allocating the memory using node::UncheckedMalloc and handles the memory allocation failure properly. Only one copy of the buffer will be created and it will be freed upon GC of the string. PR-URL: #19798 Refs: #19739 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another take of #19465 , this one puts the ERR_* helpers in the node namespace and put them inside node_errors.h instead of mingle them with the environment code.
Also fixes the long-standing issue of error messages in
buf.toStringfailures by migrating them to the new error system.The first commit is taken from #19738
Fixes: #3175
Fixes: #9489
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes