From bc6ff3a6db27b217bf6cf68e70a9112412d3453b Mon Sep 17 00:00:00 2001 From: Masashi Hirano Date: Mon, 11 Jun 2018 06:47:12 +0900 Subject: [PATCH 1/2] test: add test to check colorMode type of Console --- test/parallel/test-console-tty-colors.js | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/test/parallel/test-console-tty-colors.js b/test/parallel/test-console-tty-colors.js index 945c21f28a27de..7a91c8e091af65 100644 --- a/test/parallel/test-console-tty-colors.js +++ b/test/parallel/test-console-tty-colors.js @@ -44,3 +44,27 @@ check(true, true, true); check(false, true, true); check(true, false, false); check(false, false, false); + +// check invalid colorMode type +{ + const stream = new Writable({ + write: common.mustNotCall + }); + + [0, 'true', null, {}, [], () => {}].forEach((colorMode) => { + const received = util.inspect(colorMode); + assert.throws( + () => { + new Console({ + stdout: stream, + ignoreErrors: false, + colorMode: colorMode + }); + }, + { + message: `The argument 'colorMode' is invalid. Received ${received}`, + code: 'ERR_INVALID_ARG_VALUE' + } + ); + }); +} From dcc6edaa966959ecf40dea2dc05417e225bb1a35 Mon Sep 17 00:00:00 2001 From: shisama Date: Mon, 11 Jun 2018 19:03:13 +0900 Subject: [PATCH 2/2] test: fix Writable.write value in test for console-tty-colors Fix to set function that common.mustNotCall() returns to Writable.write --- test/parallel/test-console-tty-colors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-console-tty-colors.js b/test/parallel/test-console-tty-colors.js index 7a91c8e091af65..4f4064970ad6b7 100644 --- a/test/parallel/test-console-tty-colors.js +++ b/test/parallel/test-console-tty-colors.js @@ -48,7 +48,7 @@ check(false, false, false); // check invalid colorMode type { const stream = new Writable({ - write: common.mustNotCall + write: common.mustNotCall() }); [0, 'true', null, {}, [], () => {}].forEach((colorMode) => {