diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 818fd7cc967443..4272521a566b11 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -20,6 +20,7 @@ - [Breaking Changes to Internal Elements](#breaking-changes-to-internal-elements) - [When Breaking Changes Actually Break Things](#when-breaking-changes-actually-break-things) - [Reverting commits](#reverting-commits) + - [Additions to the Cryptography and Security APIs](#additions-to-the-cryptography-and-security-apis) - [Introducing New Modules](#introducing-new-modules) - [Deprecations](#deprecations) - [Involving the TSC](#involving-the-tsc) @@ -378,6 +379,24 @@ multiple commits. Commit metadata and the reason for the revert should be appended. Commit message rules about line length and subsystem can be ignored. A Pull Request should be raised and approved like any other change. +### Additions to the Cryptography and Security APIs + +Semver-minor commits that add or change cryptograpy APIs and Security APIs +should be treated with extra care. Due to the potential impact, it is +important that these APIs be constructed to reduce the potential for +incorrect usage. + +Semver-minor commits changing or adding cryptography or security APIs +should be made visible to the crypto team and the security working group +through an @nodejs/security-wg and @nodejs/crypto mention in the PR. + +For Semver-minor commits changing cryptography APIs, they must have +an approval from at least one member from the crypto team. + +For Semver-minor commits changing Security API's(other than those +related to cryptography) must have an approval from at least +one member from the [security working group](https://github.com/nodejs/security-wg). + ### Introducing New Modules Semver-minor commits that introduce new core modules should be treated with