From 8b626ad65e61d3810cd8ab73e40546be95556846 Mon Sep 17 00:00:00 2001
From: Ouyang Yadong <oyydoibh@gmail.com>
Date: Mon, 20 Aug 2018 13:38:27 +0800
Subject: [PATCH] worker: remove redundant function call to
 `setupPortReferencing` in `setupChild`

There is no need to call `setupPortReferencing` in `setupChild`
as which has been called with the same arguments in the `oninit`
prototype method of `MessagePort`.
---
 lib/internal/worker.js                       |  1 -
 test/parallel/test-worker-parent-port-ref.js | 25 ++++++++++++++++++++
 2 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 test/parallel/test-worker-parent-port-ref.js

diff --git a/lib/internal/worker.js b/lib/internal/worker.js
index 26c16f86e3e8fc..a1abcff567d424 100644
--- a/lib/internal/worker.js
+++ b/lib/internal/worker.js
@@ -408,7 +408,6 @@ function setupChild(evalScript) {
     if (message.type === messageTypes.LOAD_SCRIPT) {
       const { filename, doEval, workerData, publicPort, hasStdin } = message;
       publicWorker.parentPort = publicPort;
-      setupPortReferencing(publicPort, publicPort, 'message');
       publicWorker.workerData = workerData;
 
       if (!hasStdin)
diff --git a/test/parallel/test-worker-parent-port-ref.js b/test/parallel/test-worker-parent-port-ref.js
new file mode 100644
index 00000000000000..48963f320f4450
--- /dev/null
+++ b/test/parallel/test-worker-parent-port-ref.js
@@ -0,0 +1,25 @@
+// Flags: --experimental-worker
+'use strict';
+const assert = require('assert');
+const common = require('../common');
+const { isMainThread, parentPort, Worker } = require('worker_threads');
+
+// This test makes sure that we manipulate the references of
+// `parentPort` correctly so that any worker threads will
+// automatically exit when there are no any other references.
+{
+  if (isMainThread) {
+    const worker = new Worker(__filename);
+
+    worker.on('exit', common.mustCall((code) => {
+      assert.strictEqual(code, 0);
+    }), 1);
+
+    worker.on('online', common.mustCall());
+  } else {
+    const messageCallback = () => {};
+    parentPort.on('message', messageCallback);
+    // The thread won't exit if we don't make the 'message' listener off.
+    parentPort.off('message', messageCallback);
+  }
+}