-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: use print() function on both Python 2 and 3 #24493
Conversation
@jasnell @refack This change was merged into upstream in openssl/openssl#7409
ping @nodejs/security @rvagg |
Given the upstream PR was merged, it's possible we may get this in tomorrow's OpenSSL releases (we won't know for sure until the OpenSSL releases are out). (Not blocking this if we want to float a patch btw). |
I'd wait with floating this since AFAIK H/T to @cclauss who landed this upstream in openssl/openssl@83e4533 |
This is not include in OpenSSL-1.1.0 release for it is in the maintenance period. |
I do not see this change in the OpenSSL-1.1.1 tagged branch so waiting is warranted. |
I think I'd rather not merge this and just let it come in via the next OpenSSL releases since this is just for fuzzing, right? We don't do any fuzzing and I don't think we touch this path at all in any of our tools or infra. Or is someone doing fuzzing with the OpenSSL bundled with Node? (And if so .. why?) |
So there's concensus to defer this. |
Note that we need to update OpenSSL-1.1.1 before Sep. 11, 2019 and this fix will be applied to Node-v10 above before EOL of python2 on Jan. 1, 2020. |
This sounds like a good plan. |
@jasnell @refack This change was merged into upstream in openssl/openssl#7409
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes