diff --git a/lib/internal/per_context.js b/lib/internal/per_context.js index ddf874c7eac656..87fc8d247eb933 100644 --- a/lib/internal/per_context.js +++ b/lib/internal/per_context.js @@ -1,44 +1,44 @@ +// arguments: global + 'use strict'; // node::NewContext calls this script -(function(global) { - // https://github.com/nodejs/node/issues/14909 - if (global.Intl) delete global.Intl.v8BreakIterator; +// https://github.com/nodejs/node/issues/14909 +if (global.Intl) delete global.Intl.v8BreakIterator; - // https://github.com/nodejs/node/issues/21219 - // Adds Atomics.notify and warns on first usage of Atomics.wake - // https://github.com/v8/v8/commit/c79206b363 adds Atomics.notify so - // now we alias Atomics.wake to notify so that we can remove it - // semver major without worrying about V8. +// https://github.com/nodejs/node/issues/21219 +// Adds Atomics.notify and warns on first usage of Atomics.wake +// https://github.com/v8/v8/commit/c79206b363 adds Atomics.notify so +// now we alias Atomics.wake to notify so that we can remove it +// semver major without worrying about V8. - const AtomicsNotify = global.Atomics.notify; - const ReflectApply = global.Reflect.apply; +const AtomicsNotify = global.Atomics.notify; +const ReflectApply = global.Reflect.apply; - const warning = 'Atomics.wake will be removed in a future version, ' + - 'use Atomics.notify instead.'; +const warning = 'Atomics.wake will be removed in a future version, ' + + 'use Atomics.notify instead.'; - let wakeWarned = false; - function wake(typedArray, index, count) { - if (!wakeWarned) { - wakeWarned = true; +let wakeWarned = false; +function wake(typedArray, index, count) { + if (!wakeWarned) { + wakeWarned = true; - if (global.process !== undefined) { - global.process.emitWarning(warning, 'Atomics'); - } else { - global.console.error(`Atomics: ${warning}`); - } + if (global.process !== undefined) { + global.process.emitWarning(warning, 'Atomics'); + } else { + global.console.error(`Atomics: ${warning}`); } - - return ReflectApply(AtomicsNotify, this, arguments); } - global.Object.defineProperties(global.Atomics, { - wake: { - value: wake, - writable: true, - enumerable: false, - configurable: true, - }, - }); -}(this)); + return ReflectApply(AtomicsNotify, this, arguments); +} + +global.Object.defineProperties(global.Atomics, { + wake: { + value: wake, + writable: true, + enumerable: false, + configurable: true, + }, +}); diff --git a/src/node.cc b/src/node.cc index 425c1f875dd983..e01baf9726a45e 100644 --- a/src/node.cc +++ b/src/node.cc @@ -162,7 +162,6 @@ using v8::ObjectTemplate; using v8::PropertyAttribute; using v8::ReadOnly; using v8::Script; -using v8::ScriptCompiler; using v8::ScriptOrigin; using v8::SealHandleScope; using v8::SideEffectType; @@ -2500,14 +2499,16 @@ Local NewContext(Isolate* isolate, // Run lib/internal/per_context.js Context::Scope context_scope(context); - // TODO(joyeecheung): use NativeModuleLoader::Compile - Local per_context = - per_process_loader.GetSource(isolate, "internal/per_context"); - ScriptCompiler::Source per_context_src(per_context, nullptr); - Local