Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove magic numbers in test-gc-http-client-onerror #24943

Closed
wants to merge 1 commit into from
Closed

test: remove magic numbers in test-gc-http-client-onerror #24943

wants to merge 1 commit into from

Commits on Dec 13, 2018

  1. test: remove magic numbers in test-gc-http-client-onerror 

    Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC
has started and stop sending requests at that point.

On my laptop, this results in 16 or 20 requests per run instead of 500.

Fixes: nodejs#23089
    @Trott
    Trott committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    7974779 View commit details
    Browse the repository at this point in the history