From 1f25b7e32e30d7081f4c0c5d46fbcf6455c19b96 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 29 Jan 2019 11:28:27 -0800 Subject: [PATCH 1/3] tools: add test-all-suites to Makefile There is currently no Makefile target that runs every test suite. This adds one. --- Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index 7ab4a3c70f6e7b..d6aab64f8009f5 100644 --- a/Makefile +++ b/Makefile @@ -461,6 +461,10 @@ test-all: test-build ## Run everything in test/. test-all-valgrind: test-build $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release --valgrind +.PHONY: test-all-suites +test-all-suites: | bench-addons-build + $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/* + CI_NATIVE_SUITES ?= addons js-native-api node-api CI_JS_SUITES ?= default CI_DOC := doctool From d1611c55bcc9e5a08c4fbee8c00b676082f47986 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 29 Jan 2019 13:10:43 -0800 Subject: [PATCH 2/3] fixup! tools: add test-all-suites to Makefile --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index d6aab64f8009f5..a06d2762609c49 100644 --- a/Makefile +++ b/Makefile @@ -455,14 +455,14 @@ test-build-js-native-api: all build-js-native-api-tests test-build-node-api: all build-node-api-tests .PHONY: test-all -test-all: test-build ## Run everything in test/. +test-all: test-build ## Run default tests with both Debug and Release builds. $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release test-all-valgrind: test-build $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release --valgrind .PHONY: test-all-suites -test-all-suites: | bench-addons-build +test-all-suites: | bench-addons-build ## Run all test suites. $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/* CI_NATIVE_SUITES ?= addons js-native-api node-api From c0b6f8db4aaeee60776ce5edfc01c6ce7b7d7b2f Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 29 Jan 2019 14:24:53 -0800 Subject: [PATCH 3/3] fixup! fixup! tools: add test-all-suites to Makefile --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a06d2762609c49..86bb89c699b9fe 100644 --- a/Makefile +++ b/Makefile @@ -462,7 +462,7 @@ test-all-valgrind: test-build $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release --valgrind .PHONY: test-all-suites -test-all-suites: | bench-addons-build ## Run all test suites. +test-all-suites: test-build test-js-native-api test-node-api | bench-addons-build ## Run all test suites. $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/* CI_NATIVE_SUITES ?= addons js-native-api node-api