stream: use an assertion for weird error cases

[BridgeAR]

These two cases should only happen in case there's a bug in our
implementation or the user manipulated things pretty bad. So instead
of using our regular error system for these two cases, use a simple
assertion.

I guess this should be semver-major even though it has always been just a sanity check (from the original implementation on).

@nodejs/streams PTAL

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3156

[mcollina]

I don’t think we should land this, I would need to add assert to readable-stream dependencies

[BridgeAR]

@mcollina I see. In that case you should probably be fine to accept this PR as is if it lands after #26635? It removes the dependency to assert in internal/assert.

[mcollina]

I'll keep being -1. I prefer not having to load anything from internal/assert, as then it would be manual, polyfill work for readable-stream.

[BridgeAR]

@mcollina in what way would you have to polyfill that part? It only loads an internal error and AFAIC those are now also ported to readable-stream, right?

Do you suggest to keep it as is instead? We could also remove the code completely instead of keeping a sanity check shrug.

[mcollina]

@mcollina in what way would you have to polyfill that part? It only loads an internal error and AFAIC those are now also ported to readable-stream, right?

Essentially I would have to write some regular expressions to replace the usage of that module with something that does not need a require.

Do you suggest to keep it as is instead? We could also remove the code completely instead of keeping a sanity check shrug.

Yes, I would prefer to keep this as-is.

[BridgeAR]

I suggest that this is looked at again at some point since this is pretty much dead code and not coverable when not done as assertion as I did.