Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add https.Server extends tls.Server #29256

Closed
wants to merge 1 commit into from
Closed

doc: add https.Server extends tls.Server #29256

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 21, 2019

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. https Issues or PRs related to the https subsystem. labels Aug 21, 2019
@trivikr
Copy link
Member Author

trivikr commented Aug 22, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3847/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 22, 2019
@trivikr trivikr self-assigned this Aug 22, 2019
@Trott
Copy link
Member

Trott commented Aug 23, 2019

Landed in 3f71489

@Trott Trott closed this Aug 23, 2019
Trott pushed a commit that referenced this pull request Aug 23, 2019
@trivikr @Trott
doc: add https.Server extends tls.Server
3f71489 
PR-URL: #29256
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@trivikr trivikr deleted the https-doc-extends branch August 23, 2019 22:46
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@trivikr @BridgeAR
doc: add https.Server extends tls.Server
8599052 
PR-URL: #29256
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@trivikr trivikr

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. https Issues or PRs related to the https subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@trivikr @Trott @jasnell @lpinca @gengjiawen @nodejs-github-bot