From 8bccdfe57314d8c8bbb4055cbaf685855998ac77 Mon Sep 17 00:00:00 2001 From: Chetan Karande Date: Mon, 26 Aug 2019 10:02:44 -0400 Subject: [PATCH 1/2] stream: cleanup use of inner state --- lib/internal/child_process.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/internal/child_process.js b/lib/internal/child_process.js index 67687e1a07a460..4e5f301f71b184 100644 --- a/lib/internal/child_process.js +++ b/lib/internal/child_process.js @@ -298,8 +298,7 @@ function flushStdio(subprocess) { // which data can be read from a stream, e.g. being consumed on the // native layer directly as a StreamBase. if (!stream || !stream.readable || - stream._readableState.readableListening || - stream[kIsUsedAsStdio]) { + stream[kIsUsedAsStdio]) { continue; } stream.resume(); From 66b792b6a42d6a33703baf24f020f71d733d4c82 Mon Sep 17 00:00:00 2001 From: Chetan Karande Date: Wed, 28 Aug 2019 15:15:50 -0400 Subject: [PATCH 2/2] child_process: format code changes --- lib/internal/child_process.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/internal/child_process.js b/lib/internal/child_process.js index 4e5f301f71b184..8580ff64d15288 100644 --- a/lib/internal/child_process.js +++ b/lib/internal/child_process.js @@ -297,8 +297,7 @@ function flushStdio(subprocess) { // TODO(addaleax): This doesn't necessarily account for all the ways in // which data can be read from a stream, e.g. being consumed on the // native layer directly as a StreamBase. - if (!stream || !stream.readable || - stream[kIsUsedAsStdio]) { + if (!stream || !stream.readable || stream[kIsUsedAsStdio]) { continue; } stream.resume();