tools: more stringent blank-line linting for markdown files #29447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
targos
approved these changes
Sep 5, 2019
richardlau
approved these changes
Sep 5, 2019
|
|
cjihrig
approved these changes
Sep 5, 2019
trivikr
approved these changes
Sep 5, 2019
Trott
force-pushed
the
update-rpln-1.9.0
branch
from
37405dd
to
986e2c5
Compare
|
Fixed the typo in the commit message, so new Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3881/ |
lpinca
approved these changes
Sep 5, 2019
Trott
added
the
author ready
4 tasks
Trott
added a commit
that referenced
this pull request
Sep 7, 2019
PR-URL: #29447 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in ef9ecfb...1e01f3f |
Trott
force-pushed
the
update-rpln-1.9.0
branch
from
986e2c5
to
1e01f3f
Compare
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
PR-URL: #29447 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Update remark-preset-lint-node to 1.9.0, which adds linting for multiple consecutive blank lines. PR-URL: #29447 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced Sep 25, 2019
This was referenced Sep 26, 2019
targos
pushed a commit
that referenced
this pull request
Jan 8, 2020
Update remark-preset-lint-node to 1.9.0, which adds linting for multiple consecutive blank lines. PR-URL: #29447 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Update remark-preset-lint-node to 1.9.0, which adds linting for multiple consecutive blank lines. PR-URL: #29447 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update reamrk-preset-lint-node to 1.9.0, which adds linting for
multiple consecutive blank lines.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes