stream: call end(cb) callback after destroy #29859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
ronag
force-pushed
the
stream-end-cb-destroyed
branch
3 times, most recently
from
3809d0f
to
4006ad8
Compare
Don't deadlock calls to end(cb) after destroy(). This only partly fixes the problem in order to minimize breakage.
ronag
force-pushed
the
stream-end-cb-destroyed
branch
from
4006ad8
to
a022b4d
Compare
|
Merged into #29747 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't deadlock calls to end(cb) after destroy(). This only partly fixes the problem in order to minimize breakage.
This becomes relevant in the future for e.g. deprecating
fileStream.close(cb)in favor offileStream.end(cb).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes