diff --git a/src/node_version.h b/src/node_version.h index dd0f456948eaeb..37dee1e5a8b0fb 100644 --- a/src/node_version.h +++ b/src/node_version.h @@ -18,12 +18,21 @@ # else # define NODE_TAG "-pre" # endif +#else +// NODE_TAG is passed without quotes when rc.exe is run from msbuild +# define NODE_EXE_VERSION NODE_STRINGIFY(NODE_MAJOR_VERSION) "." \ + NODE_STRINGIFY(NODE_MINOR_VERSION) "." \ + NODE_STRINGIFY(NODE_PATCH_VERSION) \ + NODE_STRINGIFY(NODE_TAG) #endif # define NODE_VERSION_STRING NODE_STRINGIFY(NODE_MAJOR_VERSION) "." \ NODE_STRINGIFY(NODE_MINOR_VERSION) "." \ NODE_STRINGIFY(NODE_PATCH_VERSION) \ NODE_TAG +#ifndef NODE_EXE_VERSION +# define NODE_EXE_VERSION NODE_VERSION_STRING +#endif #define NODE_VERSION "v" NODE_VERSION_STRING diff --git a/src/res/node.rc b/src/res/node.rc index 587843df2f74c3..b2f7f3029f2a89 100644 --- a/src/res/node.rc +++ b/src/res/node.rc @@ -32,8 +32,8 @@ BEGIN VALUE "CompanyName", "Node.js" VALUE "ProductName", "Node.js" VALUE "FileDescription", "Node.js: Server-side JavaScript" - VALUE "FileVersion", "NODE_VERSION_STRING" - VALUE "ProductVersion", "NODE_VERSION_STRING" + VALUE "FileVersion", NODE_EXE_VERSION + VALUE "ProductVersion", NODE_EXE_VERSION VALUE "OriginalFilename", "node.exe" VALUE "InternalName", "node" VALUE "LegalCopyright", "Copyright Node.js contributors. MIT license."