From bcd20b22467223e35a73a757a0d9042336821773 Mon Sep 17 00:00:00 2001 From: kenzo-spaulding <51864231+kenzo-spaulding@users.noreply.github.com> Date: Fri, 24 Jan 2020 19:54:49 -0800 Subject: [PATCH 1/2] Update maintaining-V8.md Updated to conform to style guide. --- doc/guides/maintaining-V8.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/maintaining-V8.md b/doc/guides/maintaining-V8.md index 733df451b2805f..a3245d33de190f 100644 --- a/doc/guides/maintaining-V8.md +++ b/doc/guides/maintaining-V8.md @@ -30,7 +30,7 @@ For example, at the time of this writing: All older branches are abandoned and are not maintained by the V8 team. -### V8 merge process overview +### V8 Merge Process Overview The process for backporting bug fixes to active branches is officially documented [on the V8 wiki][V8MergingPatching]. The summary of the process is: From e51bc5e44f330611ba6050a8b826729d80e4d479 Mon Sep 17 00:00:00 2001 From: kenzo-spaulding <51864231+kenzo-spaulding@users.noreply.github.com> Date: Sun, 26 Jan 2020 16:11:41 -0800 Subject: [PATCH 2/2] Update maintaining-V8.md --- doc/guides/maintaining-V8.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/maintaining-V8.md b/doc/guides/maintaining-V8.md index a3245d33de190f..e20de499a4840f 100644 --- a/doc/guides/maintaining-V8.md +++ b/doc/guides/maintaining-V8.md @@ -278,7 +278,7 @@ PR-URL: https://github.com/nodejs/node/pull/7833 normal and [V8 CI][] using the Node.js CI system. We only needed to backport to `v6.x` as the other LTS branches weren't affected by this bug. -### Backports Identified by the V8 team +### Backports Identified by the V8 Team For bugs found through the browser or other channels, the V8 team marks bugs that might be applicable to the abandoned branches in use by Node.js. This is @@ -317,7 +317,7 @@ V8 builds against the version of ICU supplied by Node.js, see [maintaining-icu.md](./maintaining-icu.md) for special considerations. Specifically, a V8 update may necessitate an ICU update. -### Minor updates (patch level) +### Minor Updates (Patch Level) Because there may be floating patches on the version of V8 in Node.js, it is safest to apply the patch level updates as a patch. For example, imagine that @@ -382,7 +382,7 @@ git node v8 major --branch=5.1-lkgr This should be followed up with manual refloating of all relevant patches. -## Proposal: Using a fork repo to track upstream V8 +## Proposal: Using a Fork Repo to Track Upstream V8 The fact that Node.js keeps a vendored, potentially edited copy of V8 in deps/ makes the above processes a bit complicated. An alternative proposal would be to