doc: The default value of highWaterMark is 16KB. #31561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Trott
previously requested changes
Jan 31, 2020
There was a problem hiding this comment.
Hi, @yunnysunny! Welcome, and thank you for the pull request. Can you also fix the occurrence of kb on line 1429? That will at least keep this file consistent with itself. Unfortunately, we seem to use kb, KB, and K throughout the documents.
Change `64kb` to `64KB` in `stream.md`
|
@Trott I have corrected it. |
rexagod
approved these changes
Apr 26, 2020
ronag
approved these changes
Apr 26, 2020
ronag
added
the
author ready
puzpuzpuz
approved these changes
Apr 30, 2020
juanarbol
pushed a commit
that referenced
this pull request
Apr 30, 2020
Change `64kb` to `64KB` in `stream.md` PR-URL: #31561 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
|
Thanks for your contribution, landed in e951825 🎉 |
targos
pushed a commit
that referenced
this pull request
May 4, 2020
Change `64kb` to `64KB` in `stream.md` PR-URL: #31561 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 7, 2020
Change `64kb` to `64KB` in `stream.md` PR-URL: #31561 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
Change `64kb` to `64KB` in `stream.md` PR-URL: #31561 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of highWaterMark is
16KB, but it is16kbin the stream API document. I think it is just a spelling mistake.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes