From 60dc9cc8604aead9c1d98948015f5d2b34c92625 Mon Sep 17 00:00:00 2001 From: Denys Otrishko Date: Sun, 9 Feb 2020 11:38:45 +0200 Subject: [PATCH 1/3] lib: fix few comment typos in fs/watchers.js --- lib/internal/fs/watchers.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/internal/fs/watchers.js b/lib/internal/fs/watchers.js index 59f8bfcebcd2e3..36f1ac79d24822 100644 --- a/lib/internal/fs/watchers.js +++ b/lib/internal/fs/watchers.js @@ -78,7 +78,7 @@ StatWatcher.prototype[kFSStatWatcherStart] = function(filename, this._handle.unref(); // uv_fs_poll is a little more powerful than ev_stat but we curb it for - // the sake of backwards compatibility + // the sake of backwards compatibility. this[kOldStatus] = -1; filename = getValidatedPath(filename, 'filename'); @@ -95,9 +95,9 @@ StatWatcher.prototype[kFSStatWatcherStart] = function(filename, } }; -// To maximize backward-compatiblity for the end user, +// To maximize backward-compatibility for the end user, // a no-op stub method has been added instead of -// totally removing StatWatcher.prototpye.start. +// totally removing StatWatcher.prototype.start. // This should not be documented. StatWatcher.prototype.start = () => {}; @@ -133,7 +133,7 @@ function FSWatcher() { if (this._handle !== null) { // We don't use this.close() here to avoid firing the close event. this._handle.close(); - this._handle = null; // Make the handle garbage collectable + this._handle = null; // Make the handle is garbage collectable. } const error = errors.uvException({ errno: status, @@ -187,9 +187,9 @@ FSWatcher.prototype[kFSWatchStart] = function(filename, } }; -// To maximize backward-compatiblity for the end user, +// To maximize backward-compatibility for the end user, // a no-op stub method has been added instead of -// totally removing FSWatcher.prototpye.start. +// totally removing FSWatcher.prototype.start. // This should not be documented. FSWatcher.prototype.start = () => {}; @@ -204,7 +204,7 @@ FSWatcher.prototype.close = function() { return; } this._handle.close(); - this._handle = null; // Make the handle garbage collectable + this._handle = null; // Make the handle is garbage collectable. process.nextTick(emitCloseNT, this); }; From d7cdfca2bcb700f94b24582dfe63481624f00a88 Mon Sep 17 00:00:00 2001 From: Denys Otrishko <9109612+lundibundi@users.noreply.github.com> Date: Sun, 9 Feb 2020 13:20:18 +0200 Subject: [PATCH 2/3] fixup! Update lib/internal/fs/watchers.js Co-Authored-By: Rich Trott --- lib/internal/fs/watchers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/internal/fs/watchers.js b/lib/internal/fs/watchers.js index 36f1ac79d24822..86ff6f09020113 100644 --- a/lib/internal/fs/watchers.js +++ b/lib/internal/fs/watchers.js @@ -133,7 +133,7 @@ function FSWatcher() { if (this._handle !== null) { // We don't use this.close() here to avoid firing the close event. this._handle.close(); - this._handle = null; // Make the handle is garbage collectable. + this._handle = null; // Make the handle garbage collectable. } const error = errors.uvException({ errno: status, From 926b24793a1bae5044db2c065094c1479bd68ed0 Mon Sep 17 00:00:00 2001 From: Denys Otrishko <9109612+lundibundi@users.noreply.github.com> Date: Sun, 9 Feb 2020 13:20:27 +0200 Subject: [PATCH 3/3] fixup! Update lib/internal/fs/watchers.js Co-Authored-By: Rich Trott --- lib/internal/fs/watchers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/internal/fs/watchers.js b/lib/internal/fs/watchers.js index 86ff6f09020113..118f85d9ada181 100644 --- a/lib/internal/fs/watchers.js +++ b/lib/internal/fs/watchers.js @@ -204,7 +204,7 @@ FSWatcher.prototype.close = function() { return; } this._handle.close(); - this._handle = null; // Make the handle is garbage collectable. + this._handle = null; // Make the handle garbage collectable. process.nextTick(emitCloseNT, this); };