Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dgram: don't hide implicit bind errors #31958

Merged
merged 2 commits into from
Feb 28, 2020
Merged

dgram: don't hide implicit bind errors #31958

merged 2 commits into from
Feb 28, 2020

Commits on Feb 28, 2020

  1. dgram: don't hide implicit bind errors 

    When dgram socket implicit binding fails, an attempt is made to
clean up the send queue. This was originally implemented using
an 'error' handler that performed cleanup and then emitted a
fake error, which concealed the original error. This was done
to prevent cases where the same error was emitted twice. Now
that the errorMonitor event is available, use that to perform
the cleanup without impacting the actual error handling.

PR-URL: nodejs#31958
Refs: nodejs/help#2484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    1b2e294 View commit details
    Browse the repository at this point in the history

  2. errors: remove unused ERR_SOCKET_CANNOT_SEND error 

    This error is no longer used within core. This commit removes it.

PR-URL: nodejs#31958
Refs: nodejs/help#2484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    331d636 View commit details
    Browse the repository at this point in the history