Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document that server.address() can return null #32519

Closed
wants to merge 0 commits into from
Closed

doc: document that server.address() can return null #32519

wants to merge 0 commits into from

Conversation

watson
Copy link
Member

@watson watson commented Mar 27, 2020

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Mar 27, 2020
lpinca
lpinca reviewed Mar 27, 2020
View reviewed changes
doc/api/net.md Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Mar 27, 2020
View reviewed changes
doc/api/net.md Outdated Show resolved Hide resolved
addaleax
addaleax approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @jasnell’s suggestion applied

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2020
@Trott
Copy link
Member

Trott commented Apr 5, 2020

Landed in 04b7184

Trott pushed a commit to watson/node that referenced this pull request Apr 5, 2020
@watson @Trott
doc: document that server.address() can return null
04b7184 
PR-URL: nodejs#32519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott closed this Apr 5, 2020
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@watson @BethGriggs
doc: document that server.address() can return null
382788a 
PR-URL: #32519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
@watson @targos
doc: document that server.address() can return null
31b2cbb 
PR-URL: #32519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@watson @targos
doc: document that server.address() can return null
5996df3 
PR-URL: #32519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell left review comments

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@evanlucas evanlucas evanlucas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@watson @Trott @jasnell @evanlucas @addaleax @lpinca @nodejs-github-bot