-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc,tools: remove malfunctioning Linux manpage linker #34985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
tools
Issues and PRs related to the tools directory.
labels
Aug 30, 2020
Before: <p>On POSIX systems, the operating system release is determined by calling
<a href="https://linux.die.net/man/3/uname"></a><a href="https://linux.die.net/man/3/uname"><code>uname(3)</code></a>. After: <p>On POSIX systems, the operating system release is determined by calling
<a href="https://linux.die.net/man/3/uname"><code>uname(3)</code></a>. |
targos
approved these changes
Aug 31, 2020
lpinca
approved these changes
Aug 31, 2020
mmarchini
approved these changes
Aug 31, 2020
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 1, 2020
This comment has been minimized.
This comment has been minimized.
Trott
force-pushed
the
os-fix
branch
2 times, most recently
from
September 2, 2020 14:55
701b863
to
cc9ac42
Compare
The Linux manpage auto-linking is resulting in extraneous links with empty text in the docs. Remove it as the only thing it affects is linked explicitly in the one document that uses it. PR-URL: nodejs#34985 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Landed in cc9ac42 |
richardlau
pushed a commit
that referenced
this pull request
Sep 2, 2020
The Linux manpage auto-linking is resulting in extraneous links with empty text in the docs. Remove it as the only thing it affects is linked explicitly in the one document that uses it. PR-URL: #34985 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
richardlau
pushed a commit
that referenced
this pull request
Sep 3, 2020
The Linux manpage auto-linking is resulting in extraneous links with empty text in the docs. Remove it as the only thing it affects is linked explicitly in the one document that uses it. PR-URL: #34985 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
The Linux manpage auto-linking is resulting in extraneous links with empty text in the docs. Remove it as the only thing it affects is linked explicitly in the one document that uses it. PR-URL: #34985 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
The Linux manpage auto-linking is resulting in extraneous links with empty text in the docs. Remove it as the only thing it affects is linked explicitly in the one document that uses it. PR-URL: #34985 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
The Linux manpage auto-linking is resulting in extraneous links with empty text in the docs. Remove it as the only thing it affects is linked explicitly in the one document that uses it. PR-URL: nodejs#34985 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux manpage auto-linking is resulting in extraneous
links with empty text in the docs. Remove it as the only thing it
affects is linked explicitly in the one document that uses it.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes