test: check for AbortController existence #35616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
changed the title
Running tests comparitively on older versions of Node.js that do not have AbortController can be a pain. Only add the AbortController to knownGlobals if it actually exists. Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
test-common-conditional-abortcontroller
branch
from
2e5df10
to
2fa6e3a
Compare
github-actions
bot
removed
the
request-ci
lundibundi
approved these changes
Oct 12, 2020
ZYSzys
approved these changes
Oct 12, 2020
lpinca
approved these changes
Oct 12, 2020
aduh95
approved these changes
Oct 12, 2020
richardlau
approved these changes
Oct 12, 2020
Trott
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
LGTM although I wonder if there should be a comment to make it clear why this is being done so that someone who is puzzled by it and wants to remove it 3 years from now can do so without concern, since presumably we only care about running current test code on supported versions. Another possibility is to add in specific version-sniffing which is usually an anti-pattern but probably makes sense in this particular case as it will be self-documenting why this is being done.
jasnell
commented
Oct 13, 2020
|
Added a comment |
jasnell
added
the
author ready
|
There's really no reason for this to wait. 👍🏻 to fast-track |
github-actions
bot
removed
the
request-ci
|
Landed in 6751b6d |
jasnell
added a commit
that referenced
this pull request
Oct 15, 2020
Running tests comparitively on older versions of Node.js that do not have AbortController can be a pain. Only add the AbortController to knownGlobals if it actually exists. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35616 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Running tests comparitively on older versions of Node.js that do not have AbortController can be a pain. Only add the AbortController to knownGlobals if it actually exists. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35616 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Running tests comparitively on older versions of Node.js that do not have AbortController can be a pain. Only add the AbortController to knownGlobals if it actually exists. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#35616 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running tests comparitively on older versions of Node.js that
do not have AbortController can be a pain. Only add the
AbortController to knownGlobals if it actually exists.
Signed-off-by: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes