Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win,build,tools: support VS prerelease #36033

Closed
wants to merge 1 commit into from
Closed

win,build,tools: support VS prerelease #36033

wants to merge 1 commit into from

Conversation

baruchiro
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

I don't know if we supporting prerelease (Preview) versions, but I see there is a flow for that, so I just adjust it.

Without my change, I have both Visual Studio 19 Preview and Visual Studio 17 Enterprise, but I getting the next error:

❯ .\vcbuild.bat
Looking for Python
Python found in C:\Users\BaruchR\AppData\Local\Programs\Python\Python37\\python.exe
Looking for NASM
Looking for Visual Studio 2019
Failed to find a suitable Visual Studio installation.
Try to run in a "Developer Command Prompt" or consult
https://github.com/nodejs/node/blob/master/BUILDING.md#windows

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Nov 8, 2020
@targos
Copy link
Member

targos commented Nov 8, 2020

@nodejs/platform-windows

@Trott
Copy link
Member

Trott commented Nov 11, 2020

@nodejs/build-files

@Trott
Copy link
Member

Trott commented Nov 14, 2020

@nodejs/build

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34446/

bzoz
bzoz approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@bzoz bzoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green CI, so LGTM.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34449/

Trott
Trott approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more comfortable giving this a 👍 now that there's approval from an actual Windows user/expert.

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 20, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 20, 2020
@github-actions
Copy link
Contributor

Landed in 6312193...80a83d9

@github-actions github-actions bot closed this Nov 20, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 20, 2020
@baruchiro @nodejs-github-bot
win,build,tools: support VS prerelease
80a83d9 
PR-URL: #36033
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@baruchiro baruchiro deleted the vsPrerelease branch November 20, 2020 13:13
@Trott
Copy link
Member

Trott commented Nov 21, 2020

Thanks for the contribution! 🎉

codebytere pushed a commit that referenced this pull request Nov 22, 2020
@baruchiro @codebytere
win,build,tools: support VS prerelease
4e3883e 
PR-URL: #36033
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Nov 22, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@baruchiro @BethGriggs
win,build,tools: support VS prerelease
1b3935d 
PR-URL: #36033
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@baruchiro @BethGriggs
win,build,tools: support VS prerelease
e1b4bbf 
PR-URL: #36033
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@baruchiro @BethGriggs
win,build,tools: support VS prerelease
c4c8541 
PR-URL: #36033
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzoz bzoz bzoz approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@baruchiro @targos @Trott @nodejs-github-bot @jasnell @bzoz @richardlau