Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix more MSVC warnings #37334

Closed
wants to merge 4 commits into from
Closed

src: fix more MSVC warnings #37334

wants to merge 4 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Feb 12, 2021 •
edited
Loading

commit c0a9289

src: avoid implicit type conversions (take 2)

This fixes more C4244 MSVC warnings in the code base.

Refs: https://github.com/nodejs/node/pull/37149

commit 6e89d73

src: disable unfixable MSVC warnings

The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

commit 4f94dbc

src: fix ETW_WRITE_EMPTY_EVENT macro

A comment was written before the last line, hiding a check.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 12, 2021
@targos targos added windows Issues and PRs related to the Windows platform. lib / src Issues and PRs related to general changes in the lib or src directory. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 12, 2021
@targos
src: avoid implicit type conversions (take 2)
c0a9289 
This fixes more C4244 MSVC warnings in the code base.

Refs: nodejs#37149
@targos
src: disable unfixable MSVC warnings
6e89d73 
The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.
@targos
src: fix ETW_WRITE_EMPTY_EVENT macro
4f94dbc 
A comment was written before the last line, hiding a check.
@targos
Copy link
Member Author

targos commented Feb 12, 2021

I ended up with 4f94dbc to fix the lint error. Open to a better alternative...

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36080/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36095/

@targos
Copy link
Member Author

targos commented Feb 16, 2021

Anyone else wants to review?

targos added a commit that referenced this pull request Feb 20, 2021
@targos
src: avoid implicit type conversions (take 2)
d1f1fcf 
This fixes more C4244 MSVC warnings in the code base.

Refs: #37149

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Feb 20, 2021
@targos
src: disable unfixable MSVC warnings
5454c12 
The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Feb 20, 2021
@targos
src: fix ETW_WRITE_EMPTY_EVENT macro
a142842 
A comment was written before the last line, hiding a check.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member Author

targos commented Feb 20, 2021

Landed in 5421e15...a142842

@targos targos closed this Feb 20, 2021
@targos targos deleted the win-c4244-2 branch February 20, 2021 09:54
targos added a commit that referenced this pull request Feb 28, 2021
@targos
src: avoid implicit type conversions (take 2)
c75f5f3 
This fixes more C4244 MSVC warnings in the code base.

Refs: #37149

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Feb 28, 2021
@targos
src: disable unfixable MSVC warnings
96bcd52 
The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Feb 28, 2021
@targos
src: fix ETW_WRITE_EMPTY_EVENT macro
5ea2ed6 
A comment was written before the last line, hiding a check.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 2, 2021
Merged
targos added a commit that referenced this pull request May 27, 2021
@targos
src: avoid implicit type conversions (take 2)
e622457 
This fixes more C4244 MSVC warnings in the code base.

Refs: #37149

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request May 27, 2021
@targos
src: disable unfixable MSVC warnings
47f6a3e 
The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request May 27, 2021
@targos
src: fix ETW_WRITE_EMPTY_EVENT macro
ebbbbe4 
A comment was written before the last line, hiding a check.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request May 30, 2021
@targos
src: avoid implicit type conversions (take 2)
b6b4a08 
This fixes more C4244 MSVC warnings in the code base.

Refs: #37149

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request May 30, 2021
@targos
src: disable unfixable MSVC warnings
52a5705 
The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request May 30, 2021
@targos
src: fix ETW_WRITE_EMPTY_EVENT macro
e23f625 
A comment was written before the last line, hiding a check.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jun 5, 2021
@targos
src: avoid implicit type conversions (take 2)
babea9c 
This fixes more C4244 MSVC warnings in the code base.

Refs: #37149

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jun 5, 2021
@targos
src: disable unfixable MSVC warnings
2e527fb 
The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jun 5, 2021
@targos
src: fix ETW_WRITE_EMPTY_EVENT macro
6c1ea69 
A comment was written before the last line, hiding a check.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos added a commit that referenced this pull request Jun 11, 2021
@targos
src: avoid implicit type conversions (take 2)
38afa3f 
This fixes more C4244 MSVC warnings in the code base.

Refs: #37149

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jun 11, 2021
@targos
src: disable unfixable MSVC warnings
6b1052d 
The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jun 11, 2021
@targos
src: fix ETW_WRITE_EMPTY_EVENT macro
f5541dd 
A comment was written before the last line, hiding a check.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@targos @nodejs-github-bot @jasnell