Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix object name in prefer-assert-methods.js #37544

Closed
wants to merge 1 commit into from
Closed

tools: fix object name in prefer-assert-methods.js #37544

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 28, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36455/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 5, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/36492/ 💛

@jasnell
Copy link
Member

jasnell commented Mar 5, 2021

Landed in 54bb7e3

@jasnell jasnell closed this Mar 5, 2021
jasnell pushed a commit that referenced this pull request Mar 5, 2021
@tniessen @jasnell
tools: fix object name in prefer-assert-methods.js
54bb7e3 
PR-URL: #37544
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@tniessen @danielleadams
tools: fix object name in prefer-assert-methods.js
440c944 
PR-URL: #37544
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@tniessen @targos
tools: fix object name in prefer-assert-methods.js
e4975d9 
PR-URL: #37544
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
@tniessen tniessen deleted the tools-fix-obj-name-in-prefer-assert-methods branch October 7, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@marsonya marsonya marsonya approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tniessen @nodejs-github-bot @jasnell @lpinca @targos @marsonya @RaisinTen @aduh95