Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use .test domain for not found address #38286

Merged
merged 1 commit into from
Apr 21, 2021
Merged

test: use .test domain for not found address #38286

merged 1 commit into from
Apr 21, 2021

Commits on Apr 21, 2021

  1. test: use .test domain for not found address 

    While it is extremely unlikely that `.fhqwhgads` will become a valid
domain, we should, where possible, use one of the reserved domains for
testing.

Refs: https://tools.ietf.org/html/rfc2606

PR-URL: nodejs#38286
Refs: nodejs#38282
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @richardlau
    richardlau committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    8645a36 View commit details
    Browse the repository at this point in the history