diff --git a/common.gypi b/common.gypi index 9da5c37fb67324..505cacb938e664 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.10', + 'v8_embedder_string': '-node.11', ##### V8 defaults for Node.js ##### @@ -259,7 +259,10 @@ ], 'msvs_settings': { 'VCCLCompilerTool': { - 'AdditionalOptions': ['/Zc:__cplusplus'], + 'AdditionalOptions': [ + '/Zc:__cplusplus', + '-std:c++17' + ], 'BufferSecurityCheck': 'true', 'DebugInformationFormat': 1, # /Z7 embed info in .obj files 'ExceptionHandling': 0, # /EHsc @@ -377,7 +380,7 @@ }], [ 'OS in "linux freebsd openbsd solaris android aix cloudabi"', { 'cflags': [ '-Wall', '-Wextra', '-Wno-unused-parameter', ], - 'cflags_cc': [ '-fno-rtti', '-fno-exceptions', '-std=gnu++14' ], + 'cflags_cc': [ '-fno-rtti', '-fno-exceptions', '-std=gnu++17' ], 'defines': [ '__STDC_FORMAT_MACROS' ], 'ldflags': [ '-rdynamic' ], 'target_conditions': [ @@ -521,7 +524,7 @@ ['clang==1', { 'xcode_settings': { 'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0', - 'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++14', # -std=gnu++14 + 'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++17', # -std=gnu++17 'CLANG_CXX_LIBRARY': 'libc++', }, }], diff --git a/deps/v8/src/objects/fixed-array.h b/deps/v8/src/objects/fixed-array.h index 6b0ac5d9acaca1..8488371744fa16 100644 --- a/deps/v8/src/objects/fixed-array.h +++ b/deps/v8/src/objects/fixed-array.h @@ -138,7 +138,9 @@ class FixedArray inline void set(int index, Smi value); #else inline void set(int index, Smi value) { +#if !defined(_WIN32) DCHECK_NE(map(), GetReadOnlyRoots().fixed_cow_array_map()); +#endif DCHECK_LT(static_cast(index), static_cast(length())); DCHECK(Object(value).IsSmi()); int offset = OffsetOfElementAt(index);