doc: document node-api version process #47972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
legendecas
force-pushed
the
node-api/release
branch
from
ab68a3d to
329d62d
Compare
RafaelGSS
approved these changes
May 12, 2023
|
Please also document the process mentioned in #47975 (comment)! |
|
|
||
| and substitute this guard version with the release version `x`. | ||
|
|
||
| #### Step 4. Update test version guards |
There was a problem hiding this comment.
Suggested change
| #### Step 4. Update test version guards | |
| #### Step 3. Update test version guards |
The next step is step 4.
|
@gabrielschulhof thanks for the suggestions! I've added a section to update the change history and backport the release to LTS lines. Please take a look again. |
aymen94
approved these changes
May 17, 2023
gabrielschulhof
approved these changes
May 19, 2023
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1918241 |
fasenderos
pushed a commit
to fasenderos/node
that referenced
this pull request
May 22, 2023
PR-URL: nodejs#47972 Fixes: nodejs#47664 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47972 Fixes: nodejs#47664 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change in #45715 landed, there are several code sites that need to be updated with the release Node-API version when a new Node-API version is being released.
This PR adds a document to the guides of a checklist necessary for creating a Node-API release PR.
Fixes: #47664