-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: clarify CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED #47976
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:doc-errors-crypto-custom-engine
May 16, 2023
Merged
doc: clarify CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED #47976
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:doc-errors-crypto-custom-engine
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error is not necessarily due to a client certificate engine. For example, the `privateKeyEngine` option might just as well cause this error and is independent of the client certificate. Also mention that this is likely due to a compile-time option of OpenSSL itself and not due to any particular engine.
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
errors
Issues and PRs related to JavaScript errors originated in Node.js core.
labels
May 12, 2023
lpinca
approved these changes
May 13, 2023
tniessen
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 15, 2023
cc @nodejs/crypto |
aymen94
approved these changes
May 16, 2023
bnoordhuis
approved these changes
May 16, 2023
tniessen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 16, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 16, 2023
Landed in 32691bd |
targos
pushed a commit
that referenced
this pull request
May 30, 2023
The error is not necessarily due to a client certificate engine. For example, the `privateKeyEngine` option might just as well cause this error and is independent of the client certificate. Also mention that this is likely due to a compile-time option of OpenSSL itself and not due to any particular engine. PR-URL: #47976 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
The error is not necessarily due to a client certificate engine. For example, the `privateKeyEngine` option might just as well cause this error and is independent of the client certificate. Also mention that this is likely due to a compile-time option of OpenSSL itself and not due to any particular engine. PR-URL: #47976 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
The error is not necessarily due to a client certificate engine. For example, the `privateKeyEngine` option might just as well cause this error and is independent of the client certificate. Also mention that this is likely due to a compile-time option of OpenSSL itself and not due to any particular engine. PR-URL: nodejs#47976 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
errors
Issues and PRs related to JavaScript errors originated in Node.js core.
openssl
Issues and PRs related to the OpenSSL dependency.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is not necessarily due to a client certificate engine. For example, the
privateKeyEngine
option might just as well cause this error and is independent of the client certificate.Also mention that this is likely due to a compile-time option of OpenSSL itself and not due to any particular engine.