Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

48198 node api external strings #48339

Closed
wants to merge 31 commits into from
Closed

48198 node api external strings #48339

wants to merge 31 commits into from

Commits on Jun 7, 2023

  1. node-api: unify string creation

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    bd8045b View commit details
    Browse the repository at this point in the history

  2. node-api: add string creation benchmark

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    50a2109 View commit details
    Browse the repository at this point in the history

  3. node-api: implement external strings

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    1364872 View commit details
    Browse the repository at this point in the history

  4. add test

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    a9e24b9 View commit details
    Browse the repository at this point in the history

  5. rename to node_api_*

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    e1127d1 View commit details
    Browse the repository at this point in the history

  6. put back build type

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    953304c View commit details
    Browse the repository at this point in the history

  7. make linter work

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    09f7cdf View commit details
    Browse the repository at this point in the history

  8. rename as requested

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    902cb33 View commit details
    Browse the repository at this point in the history

  9. use std::basic_string_view to calc length in case of NAPI_AUTO_LENGTH

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    754864e View commit details
    Browse the repository at this point in the history

  10. test for auto-length

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    95a9971 View commit details
    Browse the repository at this point in the history

  11. format

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    b4f383b View commit details
    Browse the repository at this point in the history

  12. correct length

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    05317ac View commit details
    Browse the repository at this point in the history

  13. doc

    @gabrielschulhof
    gabrielschulhof committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    20ab0fb View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. use right length indicator

    @gabrielschulhof
    gabrielschulhof committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    ca4c08c View commit details
    Browse the repository at this point in the history

  2. final adjustment

    @gabrielschulhof
    gabrielschulhof committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    5de34d4 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @gabrielschulhof
    gabrielschulhof authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    64f2498 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    @gabrielschulhof @daeyeon
    gabrielschulhof and daeyeon authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    cb9d95a View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. remove utf8

    @gabrielschulhof
    gabrielschulhof committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    ed83494 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2023

  1. handle the case where we copy the string

    @gabrielschulhof
    gabrielschulhof committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    e063901 View commit details
    Browse the repository at this point in the history

  2. implement the non-copying case

    @gabrielschulhof
    gabrielschulhof committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    4ff5e53 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. Unify the two external cases

    @gabrielschulhof
    gabrielschulhof committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    402c93e View commit details
    Browse the repository at this point in the history

  2. factor out tracking

    @gabrielschulhof
    gabrielschulhof committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    32a5600 View commit details
    Browse the repository at this point in the history

  3. document

    @gabrielschulhof
    gabrielschulhof committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    0b72009 View commit details
    Browse the repository at this point in the history

  4. debug ctor dtor

    @gabrielschulhof
    gabrielschulhof committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    50dfa5d View commit details
    Browse the repository at this point in the history

  5. typo

    @gabrielschulhof
    gabrielschulhof committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    3a96b04 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review

    @gabrielschulhof
    gabrielschulhof authored Jun 11, 2023
    Configuration menu
    Copy the full SHA
    caccb8e View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review

    @gabrielschulhof
    gabrielschulhof authored Jun 11, 2023
    Configuration menu
    Copy the full SHA
    5c11c81 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. use common distructor

    @gabrielschulhof
    gabrielschulhof committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    b651fca View commit details
    Browse the repository at this point in the history

  2. format

    @gabrielschulhof
    gabrielschulhof committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    668fd4d View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    @gabrielschulhof @daeyeon
    gabrielschulhof and daeyeon authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    c721439 View commit details
    Browse the repository at this point in the history

  4. md lint

    @gabrielschulhof
    gabrielschulhof committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    7f67a2f View commit details
    Browse the repository at this point in the history