From 56ed8d906e063e24da495f2f5ad73c4d2f717912 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Fri, 14 Jul 2023 14:48:02 -0400 Subject: [PATCH 1/2] permission: fix recent coverity warning - address recent coverity warning by using auto &. Since the value is already const using a copy should not be necessary. Signed-off-by: Michael Dawson --- src/permission/fs_permission.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc index 7ae4a93fc4fcb4..fa61a164713785 100644 --- a/src/permission/fs_permission.cc +++ b/src/permission/fs_permission.cc @@ -91,7 +91,7 @@ void PrintTree(FSPermission::RadixTree::Node* node, int spaces = 0) { node->prefix); if (node->children.size()) { int child = 0; - for (const auto pair : node->children) { + for (const auto &pair : node->children) { ++child; per_process::Debug(DebugCategory::PERMISSION_MODEL, "%s Child(%s): %s\n", From 5b2ada4e20e3edefbd9413bf44df2d13171711e7 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 18 Jul 2023 10:12:34 -0400 Subject: [PATCH 2/2] squash: address linter complaints Signed-off-by: Michael Dawson --- src/permission/fs_permission.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc index fa61a164713785..bc59325e84fcd6 100644 --- a/src/permission/fs_permission.cc +++ b/src/permission/fs_permission.cc @@ -91,7 +91,7 @@ void PrintTree(FSPermission::RadixTree::Node* node, int spaces = 0) { node->prefix); if (node->children.size()) { int child = 0; - for (const auto &pair : node->children) { + for (const auto& pair : node->children) { ++child; per_process::Debug(DebugCategory::PERMISSION_MODEL, "%s Child(%s): %s\n",