doc: add notable-change label mention to PR template #49188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
aduh95
approved these changes
Aug 15, 2023
aduh95
added
author ready
|
Can non-collaborators add this label as well? If not, should we mention it? |
RaisinTen
approved these changes
Aug 16, 2023
|
Yeah, I'm not sure it's relevant here. This block of text is more for first-time contributors, who don't have the permissions to add labels anyway. |
UlisesGascon
approved these changes
Aug 16, 2023
anonrig
added
commit-queue
Well... if they don't have permission, they can ask to include it. As I said, it's just a naive attempt to remind us about this label. We're not using it often and we always need to rework the release proposal due to that. |
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7d5d640 |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
PR-URL: #49188 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR-URL: #49188 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49188 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49188 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A naive attempt to remind us about the
notable-changelabel usage.cc: @nodejs/tsc