Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix node-api call example #49395

Merged
merged 1 commit into from
Aug 31, 2023
Merged

doc: fix node-api call example #49395

merged 1 commit into from
Aug 31, 2023

Conversation

legendecas
Copy link
Member

The return statement should not be enclosed in a nested conditional
branch.

Also, the NAPI_CALL macro is renamed to NODE_API_CALL in aligning
with the n-api to node-api transition.

Fixes #49311

@legendecas
doc: fix node-api call example
f216a20 
The `return` statement should not be enclosed in a nested conditional
branch.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Aug 28, 2023
@daeyeon daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 29, 2023
mhdawson
mhdawson approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit f9a182c into nodejs:main Aug 31, 2023
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f9a182c

@legendecas legendecas deleted the node-api/doc-napi-call branch September 5, 2023 15:58
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@legendecas @UlisesGascon
doc: fix node-api call example
e5f3a69 
The `return` statement should not be enclosed in a nested conditional
branch.

PR-URL: #49395
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@legendecas @alexfernandez
doc: fix node-api call example
bf94027 
The `return` statement should not be enclosed in a nested conditional
branch.

PR-URL: nodejs#49395
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
@legendecas @targos
doc: fix node-api call example
e26b89e 
The `return` statement should not be enclosed in a nested conditional
branch.

PR-URL: #49395
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: fix node-api call example
3afcf82 
The `return` statement should not be enclosed in a nested conditional
branch.

PR-URL: nodejs/node#49395
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: fix node-api call example
a7fa6c7 
The `return` statement should not be enclosed in a nested conditional
branch.

PR-URL: nodejs/node#49395
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@aymen94 aymen94 aymen94 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@daeyeon daeyeon daeyeon approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misplaced return in NAPI_CALL example?
8 participants
@legendecas @nodejs-github-bot @lpinca @tniessen @daeyeon @mhdawson @aymen94 @HarshithaKP