doc: Fix Script with 'process,' 'path,' and 'run' Requires #49490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the script by addressing missing imports for the 'run' function and the 'path' module, which previously resulted in script failure. The following improvements have been made: - Imported 'run' from the appropriate module via require to ensure correct functionality. - Imported 'path' via require to facilitate proper file path resolution. - Imported 'process' via require to include this essential module. These changes resolve the issue of missing dependencies execution.
|
Review requested:
|
nodejs-github-bot
added
doc
|
Can you please unify the two PR's? |
|
Yes, and I need to create a new pull request after I have connected both branches together locally and pushed the unified branch to GitHub, right? @MoLow |
|
process is actually globally available so I'm not sure why we'd require it? |
You don't need to create a third PR, and it would actually be better if you didn't. My suggestion would be to edit the file at https://github.com/OshriAsulin/node/edit/patch-1/doc/api/test.md?pr=%2Fnodejs%2Fnode%2Fpull%2F49489 to include the changes on the script, and then to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the script by addressing missing imports for the 'run' function and the 'path' module, which previously resulted in script failure. The following improvements have been made:
These changes resolve the issue of missing dependencies execution.
This pr is a continuation of pr #49489